Disables a tarball fetching test on windows #6211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Why does the test load data from the internet, rather than using mocked data? |
|
I think the problem here is that those integration tests are executed by running an actual yarn process. They don't run in Jest, so they can't be mocked. I'm not entirely sure though, maybe @bestander remembers? |
Gudahtt
approved these changes
Aug 3, 2018
|
I was hoping to look into why these are failing soon. It definitely makes sense to skip them for now. The test suite is very slow and flaky on Windows right now, the tarball one being the worst. I was thinking it might be related to this issue: sindresorhus/execa#142 |
arcanis
force-pushed
the
test-win-disable
branch
from
fc06e0b
to
7da566e
Compare
arcanis
force-pushed
the
test-win-disable
branch
from
7da566e
to
2da10de
Compare
|
Are there any issue, like #4073, to track this problem? |
This was referenced Jan 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AppVeyor is constantly timeouting on the tarball fetching test.
Test plan
n/a