test: Fix yarn run <failing script> test on Windows
#6222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was failing on Windows with the following error: ``` 'false' is not recognized as an internal or external command, operable program or batch file. ``` The script used for this test is `false`. This is valid in Bash, but is not valid in cmd.exe. It has been replaced with `exit 1`, which will exit with a status of `1` in both Bash and cmd.exe The reason this test was passing on AppVeyor is that they have Cygwin installed by default. This includes a binary called `false`.
Gudahtt
force-pushed
the
fix-run-failing-test-script-on-windows
branch
from
f8b6b4b
to
b6c841d
Compare
Gudahtt
changed the title
yarn run <failing script> test on Windowsyarn run <failing script> test on Windows
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This test was failing on Windows with the following error:
The script used for this test is
false. This is valid in Bash, but isnot valid in cmd.exe. It has been replaced with
exit 1, which willexit with a status of
1in both Bash and cmd.exeThe reason this test was passing on AppVeyor is that they have Cygwin
installed by default. This includes a binary called
false.Test plan
N/A