fix(create): invoke correct path when using scoped package #6271
Conversation
When running yarn create, first the package is installed globally, however after installing create was attempting to invoke the binary from within a scope folder that did not exists. The corrects the path resolution to invoke the binary from the actual place it was installed to. fixes yarnpkg#6266
|
Looking in more details #5983 I think you're right. The initial issue was making the wrong assumption that Yarn was supposed to install binaries into I updated your code to also remove the basename, which I think was the fix we should have done back then (it seems to have been introduced in #3848, which was doing unrelated changes). |
|
Awesome thanks @arcanis. Would it be possible to release a patch with this change? |
|
@arcanis hate to be a pain here, but just wanted to bump to see if we could get a patch of this as we're currently rolling out some tooling that utilizes yarn create at my company |
|
Sure! I'll release a 1.9.5 with this change cherry-picked somewhere this week, friday at the latest 🙂 |
|
@arcanis which friday? ;) |
|
The Friday that's tomorrow? 👼 Sorry for the delay! 😬 |
|
No worries, it happens :) |
|
The 1.10 should be released (as prerelease for now) 👍 |
Summary
When running yarn create, first the package is installed globally,
however after installing create was attempting to invoke the binary from
within a scope folder that did not exists. The corrects the path
resolution to invoke the binary from the actual place it was installed
to.
fixes #6266
Test plan
This basically just removes the change introduced in #5983. I'm happy to add tests if needed but I'm unsure how to accomplish that.