chore: fix incomplete sanitization #6328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an alert that was found on LGTM: https://lgtm.com/projects/g/yarnpkg/yarn/alerts/?mode=tree&ruleFocus=1506222917439
yarn/src/util/filter.js
Lines 103 to 104 in 8cbbc6d
This replacement was incomplete, and would only replace the first backslash which is not what was intended.
Test plan
Output from node:
I'm not sure how to otherwise test this part of the code, or introduce a test case that proves that the previous version fails and the fix fixes it.