Allow Terminus to also display emojis #7093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Terminus to the list of supported terminal emulators for emoji
|
@DRSDavidSoft could you add an entry into |
|
@rally25rs Sure, I added an entry to the |
rally25rs
approved these changes
Mar 18, 2019
|
@DRSDavidSoft @rally25rs Just a heads up, shouldn't this entry be added in the master section of |
|
@rogeriopvl I see that, but in my In any case, as you point out, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add Terminus to the list of supported terminal emulators for emoji
Motivation
Since Terminus is also a xterm.js terminal emulator (same as Hyper), and recently it sets
TERM_PROGRAMtoTerminus(like how Hyper sets it toHyper), it is proper for Yarn to display Emojis also on Terminus.Example
Notice the
✨emoji on the last line: