fix(run): add cwd/node_modules/.bin to run command search path

[rally25rs]

Summary

This fixes a bug that was introduced in #6850 where the bin path was being built only from
config.lockfileFolder. However in workspaces, bins may not be hoisted to the workspace root,
causing bins to not be found. This change adds config.cwd to the bin search path, so the yarn run command will look in a workspace package's node_modules, as well as the workspace root.

fixes #7126

Test plan

Changed as existing test that placed a bin at both the workspace root and in a package. Split into 2 tests, one with the bin only at the workspace root, the other with the bin only in the package. This way we are testing that we can detect the bin in either location.

[buildsize]

File name	Previous Size	New Size	Change
yarn-[version].noarch.rpm	1.11 MB	1.11 MB	-1.62 KB (0%)
yarn-[version].js	4.48 MB	4.47 MB	-1.76 KB (0%)
yarn-legacy-[version].js	4.67 MB	4.67 MB	-1.79 KB (0%)
yarn-v[version].tar.gz	1.12 MB	1.12 MB	-563 bytes (0%)
yarn_[version]all.deb	816.66 KB	816.49 KB	-176 bytes (0%)

[farooqu]

Can this be prioritized please? It is totally broken right now for workspaces mono repos.

[Amy-Lynn]

Can this please get prioritized/merged? This is a huge issue in mono-repos

[jasonmobley]

@rally25rs can you update this PR to resolve the conflicts?
@arcanis can you review? This fixes a regression introduced by #6850 which you reviewed

In my project, I'm currently pinned on Yarn 1.14 because of the regression caused by #6850. I'd love to get back to current if we could get this PR through. The change seems ready to go if we got the conflicts fixed and could get review on it. Thanks!

[BYK]

Looks legit, thanks @rally25rs! Merge at will.

[rally25rs]

I'll resolve it this evening and get this merged. Thanks @arcanis and @jasonmobley

[rally25rs]

@arcanis the "yarn acceptance tests" had 1 failing test, only on node 8, however those tests pass locally on node 8 for me. Is there a way to re-run that test and see if it was just a hiccup in the CI test? I didn't see a "rerun" button anywhere for that test suite.

[arcanis]

For some reason I cannot log into Azure, it makes an infinite loop of signin in and immediately signing out ... 🤷‍♀️ The timeout doesn't look critical to me, let's merge. I'll make a patch release later this week.

[simonbuchan]

How does this work with cd /a/packages/b/c && yarn --cwd d some-command? I would expect it to try /a/packages/b/node_modules/.bin/some-command then /a/node_modules/.bin/some-command in /a/packages/b/c/d, assuming /a/packages/b is a package in a workspace /a.

[rally25rs]

cwd is added to the PATH before the lockfile directory (the workspace root) so I believe it will use a bin from the cwd over one from the workspace.

[simonbuchan]

Not my question. To me it looks like the current code will look in /a/packages/b/c/d/node_modules/.bin or /a/packages/b/c/node_modules/.bin first (depending on when --cwd is applied), since cwd is often not the package directory.