Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store local yarn versions as .cjs files #8145

Merged
merged 1 commit into from
May 25, 2020

Conversation

bgotink
Copy link
Member

@bgotink bgotink commented May 21, 2020

Summary

This improves the experience of working with yarn in workspaces that are marked as "type": "module" in the package.json file.

This change has also been applied in yarn 2, see yarnpkg/berry#1354

Test plan

Everything continues to work.
Even in node versions that don't explicitly support .cjs files, any unrecognised file extension is assumed to be javascript and as such any node version can load yarn as .cjs file.

This improves the experience of working with yarn
in workspaces that are marked as "type": "module"
in the package.json file.

This change has also been applied in yarn 2, see yarnpkg/berry#1354
@arcanis arcanis merged commit fc8489a into yarnpkg:master May 25, 2020
arcanis pushed a commit that referenced this pull request Aug 27, 2020
This improves the experience of working with yarn
in workspaces that are marked as "type": "module"
in the package.json file.

This change has also been applied in yarn 2, see yarnpkg/berry#1354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants