Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on mocks #2281

Open
3vilhamster opened this issue Jun 20, 2024 · 1 comment
Open

Question on mocks #2281

3vilhamster opened this issue Jun 20, 2024 · 1 comment

Comments

@3vilhamster
Copy link

Hey folks, last summer, https://github.com/golang/mock became read-only, and all users are advised to update to go.uber.org/mock for mock generation.

As far as I understand, this will be a breaking change in the current yarpc implementation, but I would like to know if there are plans to update it.
We have to create two separate controllers to handle mocks, which is imperfect.

It should be a noop change, though all users will have to regenerate mocks and update tests.

@biosvs
Copy link
Collaborator

biosvs commented Jun 20, 2024

There's an open PR #2236, we just not ready to land it yet, as we're busy with the grpc-go upgrade.

We'll think about cutting a "technical" release to include some safe PRs without behaviour changes. Hopefully it'll be done until the end of summer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants