thriftrw-plugin-yarpc: Support go.uber.org/mock #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AllenLuUber
reviewed
Dec 4, 2023
| "strings" | ||
|
|
||
| "go.uber.org/thriftrw/plugin" | ||
| "go.uber.org/thriftrw/plugin/api" | ||
| ) | ||
|
|
||
| // mock libraries | ||
| var ( |
AllenLuUber
approved these changes
Dec 4, 2023
github.com/golang/mock has been deprecated and archive and the readme now points to https://github.com/uber/mock as its successor. YARPC's thriftrw plugin assumes golang/mock. Add the ability to configure the mock runtime in the thriftrw plugin generated code to allow for golang/mock (by default to not break existing code) and uber/mock by configuration.
r-hang
force-pushed
the
rhang/uber-mock-patch
branch
from
517e4b1 to
23c8f04
Compare
AllenLuUber
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/golang/mock has been deprecated and archive and the readme now points to https://github.com/uber/mock as its successor.
YARPC's thriftrw plugin assumes golang/mock. Add the ability to configure the mock runtime in the thriftrw plugin generated code to allow for golang/mock (by default to not break existing code) and uber/mock by configuration.