Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go.uber.org/thriftrw to v1.29.2 in root, crossdock, and examples #2100

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

witriew
Copy link
Collaborator

@witriew witriew commented Sep 9, 2021

This pulls in v1.29.2 of thriftrw which contains a fix for deserializing fields
with unrecognized entries and fields with non-matching types (thriftrw/thriftrw-go#544)

  • Description and context for reviewers: one partner, one stranger
  • Docs (package doc)
  • Entry in CHANGELOG.md

This pulls in v1.29.2 of thriftrw which contains a fix for deserializing fields
with unrecognized entries and fields with non-matching types (thriftrw/thriftrw-go#544)
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #2100 (47772b3) into dev (f9c5a6e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2100   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files         249      249           
  Lines       13933    13933           
=======================================
  Hits        12208    12208           
  Misses       1335     1335           
  Partials      390      390           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c5a6e...47772b3. Read the comment docs.

@Dogild Dogild merged commit 9b6a2a5 into dev Sep 29, 2021
@Dogild Dogild deleted the witriew/bump-thriftrw branch September 29, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants