Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[protoc-gen-yarpc-go] replaces instances of deprecated ioutil package… #2239

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[protoc-gen-yarpc-go] replaces instances of deprecated ioutil package… #2239

wants to merge 1 commit into from

Conversation

lverma14
Copy link

@lverma14 lverma14 commented Dec 15, 2023 •
edited
Loading

… with io

  • Description and context for reviewers:
    This commit replaces instances of deprecated ioutil package methods with io package counterpart
    from the code generators protoc-gen-yarpc-go & protoc-gen-yarpc-go-v2.
    For eg:
- ioutil.NopCloser
+ io.NopCloser

Ref ioutil.NopCloser simply call io.NopCloser.
Internal Reference: GO-2454

  • [n/a] Docs (package doc)
  • Entry in CHANGELOG.md

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lverma14 lverma14 marked this pull request as draft December 15, 2023 23:07
@lverma14 lverma14 marked this pull request as ready for review December 19, 2023 20:56
@lverma14 lverma14 changed the title [WIP][protoc-gen-yarpc-go] replaces instances of deprecated ioutil package… [protoc-gen-yarpc-go] replaces instances of deprecated ioutil package… Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lverma14 @CLAassistant