Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit metrics for new headers handling behaviour. Hide actual changes under feature flag. #2267

Closed
wants to merge 4 commits into from

Emit metrics for reserved headers in tChannel. Hide actual changes un…

010d653
Select commit
Loading
Failed to load commit list.
Closed

Emit metrics for new headers handling behaviour. Hide actual changes under feature flag. #2267

Emit metrics for reserved headers in tChannel. Hide actual changes un…
010d653
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 22, 2024 in 1s

85.17% (target 80.00%)

View this Pull Request on Codecov

85.17% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 80.80000% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 85.17%. Comparing base (407d76c) to head (010d653).

Files Patch % Lines
transport/tchannel/response_writer.go 85.91% 5 Missing and 5 partials ⚠️
transport/http/outbound.go 42.85% 4 Missing and 4 partials ⚠️
transport/grpc/outbound.go 33.33% 3 Missing and 3 partials ⚠️
transport/http/handler.go 60.00% 3 Missing and 3 partials ⚠️
transport/tchannel/outbound.go 40.00% 4 Missing and 2 partials ⚠️
transport/grpc/handler.go 20.00% 2 Missing and 2 partials ⚠️
transport/grpc/headers.go 90.00% 2 Missing and 2 partials ⚠️
transport/tchannel/channel_outbound.go 0.00% 1 Missing and 1 partial ⚠️
transport/tchannel/handler.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2267      +/-   ##
==========================================
- Coverage   85.20%   85.17%   -0.03%     
==========================================
  Files         270      272       +2     
  Lines       15555    15687     +132     
==========================================
+ Hits        13253    13361     +108     
- Misses       1877     1890      +13     
- Partials      425      436      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov