Fix span error tagging in GO YARPC/http #2285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
biosvs
requested changes
Aug 19, 2024
|
Can we add error tag when the http status code indicates the error? e.g. where the |
ChenX1993
reviewed
Aug 27, 2024
biosvs
requested changes
Aug 29, 2024
transport/http/outbound.go
Outdated
| @@ -524,6 +523,9 @@ func getYARPCErrorFromResponse(tres *transport.Response, response *http.Response | |||
| ).WithDetails(details) | |||
|
|
|||
| if bothResponseError { | |||
| if response.StatusCode >= 400 { | |||
| UpdateSpanWithErrAndCode(span, yarpcErr, yarpcerrors.FromError(yarpcErr).Code()) | |||
There was a problem hiding this comment.
We have "code" var here, why do we need to get it via creating new error?
There was a problem hiding this comment.
Why do we even need it, if UpdateSpanWithErrAndCode already was called unconditionally at transport/http/outbound.go::317?
ChenX1993
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix span error tagging in GO YARPC/http