-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider changing element.click() to def click(*, xoffset=None, yoffset=None) #515
Comments
should not we then do the same with element.hover() ? |
Here's how Playwright does it:
– this does not help us much... nothing to follow... because it does not use offset from center, it uses absolute values starting from top left corner... and also using dict is far from perfect, because we have to use "more symbols" when writing :p |
yashaka
added a commit
that referenced
this issue
Mar 4, 2024
yashaka
added a commit
that referenced
this issue
Mar 4, 2024
implemented but yet not tested with Appium :) |
yashaka
added a commit
that referenced
this issue
Mar 6, 2024
... as it has not been fully working in context of autocompletion for now (waiting for #518 to progress on this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
subj :)
while implementing think on the following:
int | None
, or is it enough to beint
and just use 0 for same reason as None is used... kind of... do we really need None here? (to switch the implementation of the method between normal webelement.click() and actions.move_to_element_with_offset(...).click().perform()The text was updated successfully, but these errors were encountered: