-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved tests structure in files #355
Open
Elena7788
wants to merge
2
commits into
yashaka:master
Choose a base branch
from
Elena7788:#352-353_improving_test_structure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,24 +37,35 @@ def test_search_is_postponed_until_actual_action_like_questioning_displayed( | |
): | ||
page = GivenPage(session_browser.driver) | ||
page.opened_empty() | ||
|
||
element = session_browser.element('#will-be-existing-element-id') | ||
page.load_body('<h1 id="will-be-existing-element-id">Hello kitty:*</h1>') | ||
page.load_body( | ||
'<h1 id="will-be-existing-element-id">' | ||
'Hello kitty:*' | ||
'</h1>' | ||
) | ||
|
||
assert element().is_displayed() is True | ||
until_actual_action = element().is_displayed() | ||
|
||
assert until_actual_action is True | ||
|
||
|
||
def test_search_is_updated_on_next_actual_action_like_questioning_displayed( | ||
session_browser, | ||
): | ||
page = GivenPage(session_browser.driver) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same logic should be applied as in video mentioned earlier |
||
page.opened_empty() | ||
|
||
element = session_browser.element('#will-be-existing-element-id') | ||
page.load_body('<h1 id="will-be-existing-element-id">Hello kitty:*</h1>') | ||
assert element().is_displayed() is True | ||
|
||
page.load_body( | ||
'<h1 id="will-be-existing-element-id" style="display:none">Hello kitty:*</h1>' | ||
'<h1 id="will-be-existing-element-id">' | ||
'Hello kitty:*' | ||
'</h1>' | ||
) | ||
page.load_body( | ||
'<h1 id="will-be-existing-element-id" style="display:none">' | ||
'Hello kitty:*' | ||
'</h1>' | ||
) | ||
assert element().is_displayed() is False | ||
|
||
updated_actual_action = element().is_displayed() | ||
|
||
assert updated_actual_action is False |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please watch this: https://youtu.be/47yhzbiCJSw?t=1147
and refactor the test below, it should have same structure as in video;
assert should be broken into ACT and ASSERT clauses, and all previous page loading including first store of "answer" should be in ARRANGE
also
I would use the update word instead of new for consistency with test name; all this was in video;) watch it!