Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use portable-atomic, please? #13

Closed
he32 opened this issue May 6, 2024 · 3 comments
Closed

Use portable-atomic, please? #13

he32 opened this issue May 6, 2024 · 3 comments

Comments

@he32
Copy link

he32 commented May 6, 2024

Is your feature request related to a problem? Please describe.
This package will not build on systems with CPUs which lack native 64-bit atomic support, such as 32-bit powerpc. The build ends with

   Compiling rust-kanban v0.8.2 (/usr/pkgsrc/misc/rust-kanban/work/rust_kanban-0.8.2)
error[E0432]: unresolved import `std::sync::atomic::AtomicU64`
  --> src/ui/text_box.rs:17:20
   |
17 |     sync::atomic::{AtomicU64, Ordering},
   |                    ^^^^^^^^^
   |                    |
   |                    no `AtomicU64` in `sync::atomic`
   |                    help: a similar name exists in the module: `AtomicU32`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `rust-kanban` (lib) due to previous error

Describe the solution you'd like
The portable-atomic provides replacement functionality if you need to insist on 64-bit atomic operations.

Describe alternatives you've considered
As far as I know there is no other known solution to this issue.

@yashs662
Copy link
Owner

yashs662 commented May 6, 2024

I will look into this, thanks for reporting!

@yashs662
Copy link
Owner

yashs662 commented May 8, 2024

Please check if the new branch has fixed your issue, this change doesn't affect anything for regular builds at least according to the Windows, Linux, and mac-os actions, if it works for your specific configuration. I'll merge it!

@he32
Copy link
Author

he32 commented May 8, 2024

Thanks! Applying that as a patch makes the package now build on NetBSD/macppc 10.0 with rust 1.78.0.

yashs662 added a commit that referenced this issue May 10, 2024
yashs662 added a commit that referenced this issue May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants