Skip to content

Feature implementation from commits fd95030..5ea417b #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yashuatla wants to merge 18 commits into
base: feature-base-2
Choose a base branch
from
Open

Feature implementation from commits fd95030..5ea417b #2

yashuatla wants to merge 18 commits into from

Conversation

@yashuatla
Copy link
Owner

@yashuatla yashuatla commented Jun 25, 2025 •
edited by codeowlai bot
Loading

PR Summary

Refactor Galois Field Operations and Update Import Structure

Overview

This PR completely rewrites the Galois Field GF(2^8) arithmetic operations for Shamir's Secret Sharing algorithm and reorganizes import statements in the keysource file.

Change Types

Type Description
Refactor Complete rewrite of Galois Field arithmetic operations
Enhancement Addition of new inverse function for Shamir's Secret Sharing
Refactor Reorganization of import statements

Affected Modules

Module / File Change Description
shamir.go Complete rewrite of GF(2^8) arithmetic operations (div, mult, add) and addition of new inverse function
keysource.go Reorganized imports and added new dependencies (os/exec, github.com/google/shlex)

Notes for Reviewers

  • The Galois Field operations have been completely rewritten - please verify mathematical correctness
  • New dependencies have been added to keysource.go - ensure they are necessary and properly used

cgetzen and others added 18 commits July 31, 2024 17:02
@cgetzen
chore: omitempty optional metadata to reduce the size of stored config
246efde 
Signed-off-by: Charlie Getzen <charlie_g@regrello.com>
@danilobuerger
Added SOPS_AGE_KEY_CMD option to age, fixes getsops#1323
eea4b7b 
Signed-off-by: Danilo Bürger <danilo.buerger@helsing.ai>
@danilobuerger
Use shlex instead of shellquote
6c88a9d 
Signed-off-by: Danilo Bürger <danilo.buerger@helsing.ai>
@felixfontein
Merge branch 'main' into SOPS_AGE_KEY_CMD
511bebb
@felixfontein
Merge pull request getsops#1811 from danilobuerger/SOPS_AGE_KEY_CMD
051c1d8 
Added SOPS_AGE_KEY_CMD option to age, fixes getsops#1323
@cgetzen
Merge branch 'main' into cg/minimum-sops-config
496b40e
@felixfontein
Merge pull request getsops#1571 from cgetzen-forks/cg/minimum-sops-co…
e439a99 
…nfig

chore: omitempty metadata to reduce the size of stored config
@felixfontein
Update x coorindate randomization comment.
572659b 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Remove x coordinate randomization.
8bc5e92 
This isn't useful for SOPS (see removed comment), and thus only
adds unnecessary complexity. Basically un-does
hashicorp/vault@b4602fc

Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Replace GF(256) division with a constant time implementation.
8ce1179 
Copied from
hashicorp/vault@9510adc.
Please note that Vault at that point in history did not change the license yet,
so using that commit is fine.

Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Change multiplication and division functions to no longer use tables.
ec05a6f 
Copied from
hashicorp/vault@ed08e45
Please note that Vault at that point in history did not change the license yet,
so using that commit is fine.

Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Avoid unnecessary select since mult() already handles the case that a…
b6e4811 
… is zero.

Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Better document arithmetic functions.
136e271 
While writing these comments I noticed that OpenBao added similar
comments roughly a year ago:
openbao/openbao@a209a05

Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Add mul/div smoke test.
bae6742 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Merge pull request getsops#1813 from felixfontein/shamir
24ceb08 
Improve Shamir Secret Sharing code
@felixfontein
Update all dependencies with 'go get -t -u ./...'.
70ae516 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Run 'make vendor'.
09203e8 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Merge pull request getsops#1814 from felixfontein/deps
5ea417b 
Update all dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yashuatla @cgetzen @danilobuerger @felixfontein