-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing Slash Setting Ignored #119
Comments
Same issue with Eg. produces "/es" (Spanish) and I believe this has to do with the previous fix #77 |
This issue messes a lot with Google Indexing if you have all pages indexed with the trailing slash... |
I've got same problem. localizeUrl do this things. In this commit this problem maden I think. It's realy necessary to have similar with canonical hreflang structure. Temporary manually fix for me: 1. Create HeadHreflangs.astro inside /src/components/ with this code inside:
2. Replace original import from astro-i18next/components to your component file.
For me it looks like:
3. Use it, and don't forget to return the original component when the problem is fixed. |
# [1.0.0-beta.18](v1.0.0-beta.17...v1.0.0-beta.18) (2023-02-26) ### Bug Fixes * handle localizePath trailing slash depending on astro's trailingSlash config ([880666c](880666c)), closes [#119](#119) ### Features * **language-selector:** add languageMapping prop to rename languages of choice ([20d94e4](20d94e4)), closes [#116](#116)
🎉 This issue has been resolved in version 1.0.0-beta.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [1.0.0-beta.18](yassinedoghri/astro-i18next@v1.0.0-beta.17...v1.0.0-beta.18) (2023-02-26) ### Bug Fixes * handle localizePath trailing slash depending on astro's trailingSlash config ([880666c](yassinedoghri/astro-i18next@880666c)), closes [#119](yassinedoghri/astro-i18next#119) ### Features * **language-selector:** add languageMapping prop to rename languages of choice ([20d94e4](yassinedoghri/astro-i18next@20d94e4)), closes [#116](yassinedoghri/astro-i18next#116)
Describe the bug
In the
<HeadHrefLangs />
output, regardless of the setting of thetrailingSlash
config in Astro (https://docs.astro.build/en/reference/configuration-reference/#trailingslash) the output is always without them.This is contrasted to what the docs say and show (https://github.com/yassinedoghri/astro-i18next#headhreflangs-component).
To Reproduce
Deploy any website, with the package installed, setting whichever
trailingSlash
and/or site name you want, with or without trailing slash.Expected behavior
Ideally it would offer a way to configure this (or use the main Astro setting, but I'd personally prefer the setting).
Context (please complete the following information):
astro-i18next
version: [1.0.0-beta.17]astro
version: [2.0.6]The text was updated successfully, but these errors were encountered: