Use Rubocop #32
Closed
Use Rubocop #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # The point is for the user to remove these configuration records | ||
| # one by one as the offenses are removed from the code base. | ||
| # Note that changes in the inspected code, or installation of new | ||
| # versions of RuboCop, may require this file to be generated again. |
There was a problem hiding this comment.
I think in final rubocop this comment should be removed as it just confuse readers.
Style/HashSyntax: do enforce it, for new code Style/MultilineOperationIndentation: indented is right Style/VariableName: Style/MethodName: do not spell out snake_case which is the default
The impact of the bug was small because other code queried DNS anyway and filtered out the nonexistent host name.
| "For <b>Mount Point</b>, enter the path in the local file system where the directory should be mounted. With\n" + | ||
| "<b>Browse</b>, select your mount point\n" + | ||
| "For <b>Mount Point</b>, enter the path in the local " \ | ||
| "file system where the directory should be mounted. With\n" + |
There was a problem hiding this comment.
Indeed. It seems to be a Rubocop bug, already fixed: rubocop/rubocop#1474
|
I like the idea of separation common settings to an extra file ( I have some more tips for the shared part (taken from .rubocop.yml in the registration module): # align arrows:
# "foo" => true
# "foo_bar" => false
Style/AlignHash:
EnforcedHashRocketStyle: table
# no extra indentation for multiline function calls
Style/AlignParameters:
EnforcedStyle: with_fixed_indentation
# no extra indentation for case
Style/CaseIndentation:
IndentWhenRelativeTo: end
# disabled, unless should be used only in trailing form
Style/NegatedIf:
Enabled: false
# use "raise" instead of "fail"
Style/SignalException:
EnforcedStyle: only_raise |
|
LGTM |
|
Ah, .changes missing, and I want to retarget this to SLE-12-GA. |
Merged
|
Retargeting, which needs a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.