Fix unlimited-sized fake device graphs (bsc#1221222)

[shundhammer]

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1221222

Problem

Build failure of yast-storage-ng with the latest SWIG bindings.

Cause

The unit tests use DiskSize::unlimited in the YAML files for many test scenarios for LVs, and that results in a value -1 which clashes with the libstorage function prototype that expects unsigned long long for create_lvm_lv().

Obviously SWIG decides at runtime (!) which C++ function to call, and now the checks appear to be stricter: A -1 worked well until this version; it had obviously converted it to the bit pattern of the expected unsigned type, in this case resulting in 16 EiB - 1. Now that doesn't work anymore.

Fix

Don't use unlimited for LVM LVs in the YAML fake device graphs; that's unrealistic and not possible in real life anyway.

This fix is limited purely to unit test data. There is no code change.

Related PRs

• Backport to SLE-15-SP6: Fix unlimited-sized fake device graphs (bsc#1221222) [SLE-15-SP6 Backport] #1378
• Alternative PR: (Revoked, did not find agreement) Don't pass -1 to unsigned long long in swig bindings (bsc#1221222) #1374

[coveralls]

coverage: 97.81%. remained the same
when pulling e8f9426 on huha-no-unlimited-lvs
into b3e7d0d on master.

[aschnell]

LGTM

[yast-bot]

❌ Internal Jenkins job #1149 failed

[shundhammer]

Submitted manually to Factory:

https://build.opensuse.org/request/show/1157596

[yast-bot]

✔️ Internal Jenkins job #1150 successfully finished
✔️ Created OBS submit request #1157604