Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: xray integration #143

Merged
merged 15 commits into from
Mar 19, 2024
Merged

feat: xray integration #143

merged 15 commits into from
Mar 19, 2024

Conversation

Zubs
Copy link
Contributor

@Zubs Zubs commented Mar 14, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • XRAY Integration

Does this introduce a breaking change?

  • Yes
  • No

Does this introduce UI changes? If so, have they been tested on both dark and light modes?

  • Yes
  • No

Other information

@Zubs Zubs requested a review from dacoaster as a code owner March 14, 2024 00:30
@dacoaster dacoaster changed the title feat: major refactor feat: xray integration Mar 15, 2024
@dacoaster
Copy link
Collaborator

@Zubs - Please rebase this on the ok/integration branch instead of main.

@Zubs Zubs changed the base branch from main to ok/integration March 15, 2024 16:23
@Zubs
Copy link
Contributor Author

Zubs commented Mar 15, 2024

@Zubs - Please rebase this on the ok/integration branch instead of main.

Done

dacoaster
dacoaster requested changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@dacoaster dacoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once these fixes are done I can review again.

src/components/ControlPanel.vue Outdated Show resolved Hide resolved
src/components/settings/ConnectionsTab.vue Show resolved Hide resolved
src/components/authentication/SigninXrayWrapper.vue Show resolved Hide resolved
src/components/authentication/SigninXrayWrapper.vue Outdated Show resolved Hide resolved
src/integrations/XrayIntegrationHelpers.js Outdated Show resolved Hide resolved
src/components/xray/XrayExportSession.vue Show resolved Hide resolved
src/components/xray/XrayExportSession.vue Outdated Show resolved Hide resolved
src/components/xray/XrayExportSession.vue Show resolved Hide resolved
src/components/xray/XrayExportSession.vue Outdated Show resolved Hide resolved
src/components/xray/XrayExportSession.vue Outdated Show resolved Hide resolved
@Zubs Zubs requested a review from dacoaster March 18, 2024 15:24
dacoaster
dacoaster requested changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@dacoaster dacoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zubs - This is looking good its very close to ready

src/components/xray/XrayExportSession.vue Outdated Show resolved Hide resolved
src/components/authentication/SigninXrayWrapper.vue Outdated Show resolved Hide resolved
src/components/authentication/SigninXrayWrapper.vue Show resolved Hide resolved
src/integrations/XrayIntegrationHelpers.js Show resolved Hide resolved
@Zubs Zubs requested a review from dacoaster March 18, 2024 19:32
@dacoaster dacoaster merged commit 7315020 into testfiesta:ok/integration Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacoaster dacoaster dacoaster requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zubs @dacoaster @isntlazy