Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more descriptive error message on audio error #98

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

isntlazy
Copy link
Contributor

@isntlazy isntlazy commented Dec 6, 2023

More descriptive audio error message

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Translation

What is the current behavior?

If user does not have any audio input devices connected we are just showing: An error occurred while recording the audio.

Issue Number: #86

What is the new behavior?

More descriptive message: An error occurred while recording the audio. Please make sure you have at least one audio input device connected

Does this introduce a breaking change?

  • Yes
  • No

Does this introduce UI changes? If so, have they been tested on both dark and light modes?

  • Yes
  • No

Other information

@isntlazy isntlazy requested a review from dacoaster as a code owner December 6, 2023 13:45
@isntlazy isntlazy self-assigned this Dec 6, 2023
@dacoaster dacoaster merged commit 1b7317b into main Dec 6, 2023
1 check failed
@dacoaster dacoaster deleted the ok/audio-recording-error-message branch December 6, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants