-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
econ socket is not closed on SIGTERM and SIGINT #68
Comments
I think that this is outside the scope of infclass. Maybe the offical teeworlds repo can get answers? |
We maintain a full disconnected copy of teeworlds code and haven't updated it in many years. Our code is different from theirs right now. Even if it should/was/is being fixed in the teeworlds repo, the fix still needs to be backported to our code manually. Also, TIL that SIGTERM is not the signal that is sent upon ^C. The signal sent upon ^C is SIGINT. Another thing i learned about is SO_REUSEADDR/SO_REUSEPORT, which is probably what we need. As far as i understand, it should be set somewhere in teeworlds-infclassR/src/base/system.c Line 914 in e0eca10 |
i dont know much about this, but maybe this helps: |
We have this patch applied, it still does not help |
Why does this bug have label "wontfix"? |
Because no one is able to fix it! |
When i stop infclass process via
SIGINT
(in my case i just pressCtrl-C
) orSIGTERM
(viakill <pid>
) econ socket is not getting closed. Because of it, i cannot restart the server immediately and have to wait for 60 seconds.Steps to reproduce:
telnet <ip> 8309
, you will see password prompt)Ctrl-C
Expected: connection to econ succeeds
Observed: connection fails; in server log there is message about the server not being able to open a socket
The text was updated successfully, but these errors were encountered: