Add SO_REUSEPORT to econ socket #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to fix the issue i am having with restarting the server fast enough. Closes necropotame#68
|
if it works, you can merge it when you want. |
bretonium
commented
Feb 11, 2019
| @@ -912,6 +913,10 @@ static int priv_net_create_socket(int domain, int type, struct sockaddr *addr, i | |||
| } | |||
| #endif | |||
|
|
|||
| if (setsockopt(sock, SOL_SOCKET, SO_REUSEPORT, &(int){ 1 }, sizeof(int)) < 0) { | |||
There was a problem hiding this comment.
i think this will not work on windows. Maybe i need SO_REUSEADDR...
|
Lets see what smart folks from teeworlds/teeworlds#2034 say |
duralakun
reviewed
Feb 12, 2019
|
How it the state of this PR? Can we merge it? |
|
We are waiting for the upstream fix and comments. What we have here should not be merged. |
teoman002
added
hard-to-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to fix the issue i am having with restarting the server.
Closes #68