-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make scoring only possible with a higher amount of players on server #144
Conversation
A better solution would be to add a column But as said. I can test if the code compiles. I can't test if it works because I still havent figured out how to init the databases Need to tell me what solution should be implemnted and somebody else got to test it then, though. |
@teoman002 maybe you decide which solution because you tagged me :D or @bretonium knows if changing the database schema causes trouble |
solution 1 seems simple, so I suggest to do that. We can improve the code later™. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, it does not compile
By itself it doesn't, but we do not have the necessary infrastructure to automate schema migration, and asking administrators to do the migration manually, via .sql file, is a pain. We could add a check that the migration was applied and exit if it wasn't, but it is too much hassle for a simple issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be good
@@ -4218,7 +4218,10 @@ class CSqlJob_Server_SendPlayerStatistics : public CSqlJob | |||
void UpdateScore(CSqlServer* pSqlServer, int ScoreType, int Score, const char* pScoreName) | |||
{ | |||
char aBuf[512]; | |||
|
|||
|
|||
if (m_pServer->GetActivePlayerCount() > 8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> 8
LOL
|
||
|
||
if (m_pServer->GetActivePlayerCount() > 8) | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what this line without ;
in the end does
Would solve #135