Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation issue #9

Closed
ralaud opened this issue Jun 3, 2019 · 4 comments
Closed

Translation issue #9

ralaud opened this issue Jun 3, 2019 · 4 comments

Comments

@ralaud
Copy link

ralaud commented Jun 3, 2019

Hi, my country id was denmark and it was not translated. Instead of using english language, it was using the turkish translated strings.
I would recommend to outcomment all not translated cases for now and add case default with english language.

This may solve it (check case default, I dont know if it is right).

src/game/server/gamemodes/mod.cpp (line 561 to 734)

		/* ar - Arabic ************************************/
	/*case 12: //Algeria
	case 48: //Bahrain
	case 262: //Djibouti
	case 818: //Egypt
	case 368: //Iraq
	case 400: //Jordan
	case 414: //Kuwait
	case 422: //Lebanon
	case 434: //Libya
	case 478: //Mauritania
	case 504: //Morocco
	case 512: //Oman
	case 275: //Palestine
	case 634: //Qatar
	case 682: //Saudi Arabia
	case 706: //Somalia
	case 729: //Sudan
	case 760: //Syria
	case 788: //Tunisia
	case 784: //United Arab Emirates
	case 887: //Yemen
		// set to arabic
		break;*/
		/* bg - Bulgarian *************************************/
	/*case 100: //Bulgaria
		// set to bulgarian
		break;*/
		/* bs - Bosnian *************************************/
	/*case 70: //Bosnia and Hercegovina
		// set to bosnian
		break;*/
		/* cs - Czech *************************************/
	/*case 203: //Czechia
		// set to czech
		break;*/
		/* de - German ************************************/
	case 40: //Austria
	case 276: //Germany
	case 438: //Liechtenstein
	case 756: //Switzerland
		players[ClientID]->SetLanguage("german");
		break;
		/* el - Greek ***********************************/
	/*case 300: //Greece
	case 196: //Cyprus
		// set to greek
		break;*/
		/* es - Spanish ***********************************/
	case 32: //Argentina
	case 68: //Bolivia
	case 152: //Chile
	case 170: //Colombia
	case 188: //Costa Rica
	case 192: //Cuba
	case 214: //Dominican Republic
	case 218: //Ecuador
	case 222: //El Salvador
	case 226: //Equatorial Guinea
	case 320: //Guatemala
	case 340: //Honduras
	case 484: //Mexico
	case 558: //Nicaragua
	case 591: //Panama
	case 600: //Paraguay
	case 604: //Peru
	case 630: //Puerto Rico
	case 724: //Spain
	case 858: //Uruguay
	case 862: //Venezuela
		players[ClientID]->SetLanguage("spanish");
		break;
		/* fa - Farsi ************************************/
	/*case 364: //Islamic Republic of Iran
	case 4: //Afghanistan
		// set to farsi
		break;*/
		/* fr - French ************************************/
	case 204: //Benin
	case 854: //Burkina Faso
	case 178: //Republic of the Congo
	case 384: //Cote d’Ivoire
	case 266: //Gabon
	case 324: //Ginea
	case 466: //Mali
	case 562: //Niger
	case 686: //Senegal
	case 768: //Togo
	case 250: //France
	case 492: //Monaco
		players[ClientID]->SetLanguage("french");
		break;
		/* hr - Croatian **********************************/
	/*case 191: //Croatia
		// set to croatian
		break;*/
		/* hu - Hungarian *********************************/
	case 348: //Hungary
		players[ClientID]->SetLanguage("hungarian");
		break;
		/* it - Italian ***********************************/
	/*case 380: //Italy
		// set to italian
		break;*/
		/* ja - Japanese **********************************/
	/*case 392: //Japan
		// set to japanese
		break;*/
		/* la - Latin *************************************/
	/*case 336: //Vatican
		// set to latin
		break;*/
		/* nl - Dutch *************************************/
	/*case 533: //Aruba
	case 531: //Curaçao
	case 534: //Sint Maarten
	case 528: //Netherland
	case 740: //Suriname
	case 56: //Belgique
		// set to dutch
		break;*/
		/* pl - Polish *************************************/
	case 616: //Poland
		players[ClientID]->SetLanguage("polish");
		break;
		/* pt - Portuguese ********************************/
	/*case 24: //Angola
	case 76: //Brazil
	case 132: //Cape Verde
	//case 226: //Equatorial Guinea: official language, but not national language
	//case 446: //Macao: official language, but spoken by less than 1% of the population
	case 508: //Mozambique
	case 626: //Timor-Leste
	case 678: //São Tomé and Príncipe
		// set to portuguese
		break;*/
		/* ru - Russian ***********************************/
	case 112: //Belarus
	case 643: //Russia
	case 398: //Kazakhstan
	case 498: //Moldova
		players[ClientID]->SetLanguage("russian");
		break;
		/* sk - Slovak ************************************/
	/*case 703: //Slovakia
		// set to slovak
		break;*/
		/* sr - Serbian ************************************/
	/*case 688: //Serbia
		// set to serbian
		break;*/
		/* tl - Tagalog ************************************/
	/*case 608: //Philippines
		// set to tagalog
		break;*/
		/* tr - Turkish ************************************/
	case 31: //Azerbaijan
	case 792: //Turkey
		players[ClientID]->SetLanguage("turkish");
		break;
		/* uk - Ukrainian **********************************/
	case 804: //Ukraine
		players[ClientID]->SetLanguage("ukrainian");
		break;
		/* zh-Hans - Chinese (Simplified) **********************************/
	/*case 156: //People’s Republic of China
	case 344: //Hong Kong
	case 446: //Macau
		// set to chinese
		break;*/
	/*case default
		players[ClientID]->SetLanguage("english");	//Chose default english, if the string is not tranlated and outcomment untranslated for now
   		break;*/
	}

Best regards,
ralaud

@ralaud ralaud changed the title Translated strings issue Translation issue Jun 3, 2019
@yavl
Copy link
Owner

yavl commented Jun 6, 2019

was your flag detected as Turkish? If so, a chat command could be added later to switch back to english

@ralaud
Copy link
Author

ralaud commented Jun 8, 2019

It was detected as denmark flag. And today I tried with Netherlands VPN, it detected Netherland flag and its the same behaviour. So my conclusion is, that only not translated languages get this behaviour.

But I looked up closer now.

It is just this part, which is translated in turkish, even if it was detected as denmark flag:

file: /bin/translations.json

This part I did test:

	{
		"context": "turkish",
		"or": "Infected won the round in %d seconds",
		"tr": "Zombiler bu eli %d sürede kazandılar saniye"
	},

This part, I was not able to test yet:

	{
		"context": "turkish",
		"or": "%d humans won the round",
		"tr": "%d insan bu eli kazandı"
	},
	{
		"context": "turkish",
		"or": "You have survived, +5 points",
		"tr": "Hayatta kaldınız, +5 puan"
	},
]
}

The rest (the menu for choosing the class) will be shown in english.

Attachment:
screenshot

yavl added a commit that referenced this issue Jun 9, 2019
@ralaud
Copy link
Author

ralaud commented Jun 11, 2019

Thanks, now it is translating in english :)

@ralaud ralaud closed this as completed Jun 11, 2019
@yavl
Copy link
Owner

yavl commented Jan 27, 2020

present after e8a617d

@yavl yavl reopened this Jan 27, 2020
@yavl yavl closed this as completed in 49c4ca0 Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants