Skip to content

19064: Explicit Type Import #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kaustubh1204 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

19064: Explicit Type Import #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import "./style.css";
import * as echarts from "echarts";
import type { CallbackDataParams } from "echarts/types/dist/shared";

document.addEventListener("DOMContentLoaded", () => {
const chartContainer = document.getElementById("app");
Expand All @@ -22,22 +23,18 @@ document.addEventListener("DOMContentLoaded", () => {
{
data: [150, 230, 224, 218, 135, 147, 260],
type: "line",
name: "Weekly Data", // Add a name so seriesName has a value
},
],

// tooltip: {
// formatter: (params) => {
// return `${params.name}, ${params.seriesName}`; // BUG: `name` and `seriesName` are unavailable because of incorrect typing
// },
// },

// Awkward workaround to access `name` and `seriesName` fields without a TypeScript error (this shouldn't ):
tooltip: {
formatter: ((params: echarts.DefaultLabelFormatterCallbackParams) => {
return `${params.name}, ${params.seriesName}`;
}) as echarts.TooltipComponentFormatterCallback<echarts.TooltipComponentFormatterCallbackParams>,
trigger: "axis", // or "item"
formatter: (params) => {
const param = (Array.isArray(params) ? params[0] : params) as CallbackDataParams;
return `${param.name}, ${param.seriesName || 'Series'}`;
},
},
};

chart.setOption(option);
});
});