Bugfix/add save page test #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @yazdipour - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -16,8 +20,7 @@ def __init__(self, api_token: str, graphql_endpoint_url: str = "https://api-prod | |||
| headers={"content-type": "application/json", "authorization": api_token}, | |||
| use_json=True, | |||
| ) | |||
| self.client = Client(transport=transport, | |||
| fetch_schema_from_transport=False) | |||
| self.client = Client(transport=transport, fetch_schema_from_transport=False) | |||
There was a problem hiding this comment.
suggestion (code_refinement): Consider enabling schema fetching from transport for development.
Fetching the schema can be useful during development to catch breaking changes in the GraphQL schema. It might be beneficial to allow this to be configurable via an optional parameter.
Suggested change
| self.client = Client(transport=transport, fetch_schema_from_transport=False) | |
| def __init__(self, transport, fetch_schema=False): | |
| self.client = Client(transport=transport, fetch_schema_from_transport=fetch_schema) |
| if arg.startswith(variable_name + '='): | ||
| return arg.split('=')[1] | ||
| dotenv_path = os.path.join(os.path.dirname(__file__), '.env') | ||
| if arg.startswith(variable_name + "="): |
There was a problem hiding this comment.
suggestion (code-quality): Use f-string instead of string concatenation (use-fstring-for-concatenation)
Suggested change
| if arg.startswith(variable_name + "="): | |
| if arg.startswith(f"{variable_name}="): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #IssueNr
📑 Description
✅ Checks
ℹ Additional Information