Skip to content

Commit

Permalink
feat(import): use core rule instead of plugin rule (#786)
Browse files Browse the repository at this point in the history
The `eslint-plugin-import` document says:

> If the core ESLint version is good enough (...), keep it and don't use this.

Note that `@typescript-eslint/no-duplicate-imports` also is present now.
  • Loading branch information
ybiquitous authored Oct 7, 2020
1 parent 3f4d239 commit 0d6546d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion rules/core/es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = {
"no-class-assign": "error",
"no-const-assign": "error",
"no-dupe-class-members": "error",
"no-duplicate-imports": "off", // => `import/no-duplicates`
"no-duplicate-imports": "error",
"no-new-symbol": "error",
"no-restricted-exports": "off",
"no-restricted-imports": "off",
Expand Down
1 change: 1 addition & 0 deletions rules/plugins/import.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ module.exports = {
"import/no-cycle": "error",
"import/no-default-export": "off",
"import/no-deprecated": "error",
"import/no-duplicates": "off", // use core rule `no-duplicate-imports`
"import/no-dynamic-require": "warn",
"import/no-extraneous-dependencies": [
"error",
Expand Down

0 comments on commit 0d6546d

Please sign in to comment.