fix(node): remove core Node.js rules (#678)

The Node.js rules included in ESLint core was deprecated with ESLint v7.
See https://eslint.org/docs/user-guide/migrating-to-7.0.0#deprecate-node-rules

index.js

@@ -6,7 +6,6 @@ module.exports = {
     "./rules/core/variables.js",
     "./rules/core/styles.js",
     "./rules/core/es6.js",
-    "./rules/core/node.js",
     "./rules/plugins/prettier.js",
     "./rules/plugins/eslint-comments.js",
     "./rules/plugins/import.js",

test/check-rules.test.js

@@ -4,7 +4,7 @@ const { $, lintConfigFiles } = require("./helper");
 
 const checkRules = (file, option, env = {}) => {
   try {
-    $("eslint-find-rules", option, file, { env });
+    $("eslint-find-rules", "--verbose", option, file, { env });
   } catch (err) {
     const { stdout, stderr } = err;
     if (typeof stdout === "string" && stdout !== "") {
@@ -18,8 +18,37 @@ const checkRules = (file, option, env = {}) => {
 };
 
 test("no unused rules", (t) => {
+  const deprecatedRules = [
+    // NOTE: Node-specific rules are deprecated and will be removed.
+    // See https://eslint.org/docs/user-guide/migrating-to-7.0.0#deprecate-node-rules
+    "callback-return",
+    "global-require",
+    "handle-callback-err",
+    "no-buffer-constructor",
+    "no-mixed-requires",
+    "no-new-require",
+    "no-path-concat",
+    "no-process-env",
+    "no-process-exit",
+    "no-restricted-modules",
+    "no-sync",
+  ];
+
   lintConfigFiles.forEach((file) => {
-    checkRules(file, "--unused");
+    try {
+      checkRules(file, "--unused");
+    } catch (err) {
+      if (typeof err.stdout === "string") {
+        const msgs = deprecatedRules
+          .filter((rule) => err.stdout.includes(`${rule} `))
+          .map((rule) => `  --> "${rule}" is deprecated`);
+        if (msgs.length !== 0) {
+          process.stderr.write(msgs.join(EOL) + EOL);
+          return;
+        }
+      }
+      throw err;
+    }
     t.pass(file);
   });
   t.end();
@@ -38,14 +67,11 @@ test("deprecated rules", (t) => {
       checkRules(file, "--deprecated", { ESLINT_CONFIG_PRETTIER_NO_DEPRECATED: "true" });
     } catch (err) {
       if (typeof err.stdout === "string") {
-        const msg = ignoredRules
-          .filter((rule) => err.stdout.includes(rule))
-          .map(
-            (rule) => `  => "${rule}" is deprecated but included in the recommended config${EOL}`
-          )
-          .join("");
-        if (msg) {
-          process.stderr.write(msg);
+        const msgs = ignoredRules
+          .filter((rule) => err.stdout.includes(`${rule} `))
+          .map((rule) => `  --> "${rule}" is deprecated but included in the recommended config`);
+        if (msgs.length !== 0) {
+          process.stderr.write(msgs.join(EOL) + EOL);
           return;
         }
       }