[READY] Force MSVC to treat source files as UTF-8 encoded #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1015 +/- ##
==========================================
+ Coverage 97.04% 97.08% +0.04%
==========================================
Files 88 88
Lines 6909 6904 -5
==========================================
- Hits 6705 6703 -2
+ Misses 204 201 -3 |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
@zzbot r+ Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
📌 Commit 4ddf4cf has been approved by |
zzbot
added a commit
that referenced
this pull request
Apr 26, 2018
[READY] Force MSVC to treat source files as UTF-8 encoded Compilation fails with a lot of these errors: ``` error C3688: invalid literal suffix '唷'; literal operator or literal operator template 'operator ""唷' not found ``` when the system local is Chinese on Windows. This is fixed by forcing MSVC to use UTF-8. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1015) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
@zzbot retry Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
zzbot
added a commit
that referenced
this pull request
Apr 27, 2018
[READY] Force MSVC to treat source files as UTF-8 encoded Compilation fails with a lot of these errors: ``` error C3688: invalid literal suffix '唷'; literal operator or literal operator template 'operator ""唷' not found ``` when the system local is Chinese on Windows. This is fixed by forcing MSVC to use UTF-8. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1015) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-appveyor, status-travis |
zzbot
added a commit
to ycm-core/YouCompleteMe
that referenced
this pull request
May 2, 2018
[READY] Update ycmd Include the following changes: - PR ycm-core/ycmd#919: cache include paths; - PR ycm-core/ycmd#1013: increase Python 2 requirement to 2.7.1; - PR ycm-core/ycmd#1015: force MSVC to treat source files as UTF-8 encoded; - PR ycm-core/ycmd#1017: bundle and compile the regex module; - PR ycm-core/ycmd#1020: use `sysconfig` instead of `distutils.sysconfig` in build script. Fixes #3001. Fixes #3007. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3010) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation fails with a lot of these errors:
when the system local is Chinese on Windows. This is fixed by forcing MSVC to use UTF-8.
This change is