Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend regex in read.xlsx to allow .xlsm files; solves #209 #210

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

dseynaev
Copy link
Contributor

@dseynaev dseynaev commented Jun 29, 2021

solves #209

@JanMarvin
Copy link
Collaborator

also #205

@codecov-commenter
Copy link

Codecov Report

Merging #210 (ccc5ed3) into master (c918852) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   65.44%   65.44%           
=======================================
  Files          34       34           
  Lines        8879     8879           
=======================================
  Hits         5811     5811           
  Misses       3068     3068           
Impacted Files Coverage Δ
R/readWorkbook.R 87.68% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 114cfa5...ccc5ed3. Read the comment docs.

@ycphs ycphs merged commit 472c27d into ycphs:master Jun 29, 2021
@dseynaev dseynaev deleted the patch_read_xlsx_regex branch June 30, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants