[Security Solution][Lists] - Tests cleanup and remove unnecessary imp…

…ort (elastic#73865)

## Summary

Addresses feedback from elastic#72748

- Updates `plugins/lists` tests text from `should not validate` to `should FAIL validation` after feedback that previous text is a bit confusing and can be interpreted to mean that validation is not conducted
- Remove unnecessary spreads from one of my late night PRs
- Removes `siem_common_deps` in favor of `shared_imports` in `plugins/lists`
- Updates `build_exceptions_query.test.ts` to use existing mocks

x-pack/plugins/lists/common/schemas/common/schemas.test.ts

@@ -7,7 +7,7 @@
 import { pipe } from 'fp-ts/lib/pipeable';
 import { left } from 'fp-ts/lib/Either';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import {
   EsDataTypeGeoPoint,

x-pack/plugins/lists/common/schemas/common/schemas.ts

@@ -9,7 +9,7 @@
 import * as t from 'io-ts';
 
 import { DefaultNamespace } from '../types/default_namespace';
-import { DefaultStringArray, NonEmptyString } from '../../siem_common_deps';
+import { DefaultStringArray, NonEmptyString } from '../../shared_imports';
 
 export const name = t.string;
 export type Name = t.TypeOf<typeof name>;

x-pack/plugins/lists/common/schemas/elastic_response/search_es_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { pipe } from 'fp-ts/lib/pipeable';
 import { left } from 'fp-ts/lib/Either';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { SearchEsListItemSchema, searchEsListItemSchema } from './search_es_list_item_schema';
 import { getSearchEsListItemMock } from './search_es_list_item_schema.mock';
@@ -22,7 +22,7 @@ describe('search_es_list_item_schema', () => {
     expect(message.schema).toEqual(payload);
   });
 
-  test('it should not validate with a madeup value', () => {
+  test('it should FAIL validation when a madeup value', () => {
     const payload: SearchEsListItemSchema & { madeupValue: string } = {
       ...getSearchEsListItemMock(),
       madeupValue: 'madeupvalue',

x-pack/plugins/lists/common/schemas/elastic_response/search_es_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { pipe } from 'fp-ts/lib/pipeable';
 import { left } from 'fp-ts/lib/Either';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { SearchEsListSchema, searchEsListSchema } from './search_es_list_schema';
 import { getSearchEsListMock } from './search_es_list_schema.mock';
@@ -22,7 +22,7 @@ describe('search_es_list_schema', () => {
     expect(message.schema).toEqual(payload);
   });
 
-  test('it should not validate with a madeup value', () => {
+  test('it should FAIL validation when a madeup value', () => {
     const payload: SearchEsListSchema & { madeupValue: string } = {
       ...getSearchEsListMock(),
       madeupValue: 'madeupvalue',

x-pack/plugins/lists/common/schemas/request/create_endpoint_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 import { getCreateCommentsArrayMock } from '../types/create_comment.mock';
 import { getCommentsMock } from '../types/comment.mock';
 import { CommentsArray } from '../types';

x-pack/plugins/lists/common/schemas/request/create_endpoint_list_item_schema.ts

@@ -22,7 +22,7 @@ import {
 import { RequiredKeepUndefined } from '../../types';
 import { CreateCommentsArray, DefaultCreateCommentsArray, nonEmptyEntriesArray } from '../types';
 import { EntriesArray } from '../types/entries';
-import { DefaultUuid } from '../../siem_common_deps';
+import { DefaultUuid } from '../../shared_imports';
 
 export const createEndpointListItemSchema = t.intersection([
   t.exact(

x-pack/plugins/lists/common/schemas/request/create_exception_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 import { getCreateCommentsArrayMock } from '../types/create_comment.mock';
 import { getCommentsMock } from '../types/comment.mock';
 import { CommentsArray } from '../types';

x-pack/plugins/lists/common/schemas/request/create_exception_list_item_schema.ts

@@ -29,7 +29,7 @@ import {
   nonEmptyEntriesArray,
 } from '../types';
 import { EntriesArray } from '../types/entries';
-import { DefaultUuid } from '../../siem_common_deps';
+import { DefaultUuid } from '../../shared_imports';
 
 export const createExceptionListItemSchema = t.intersection([
   t.exact(

x-pack/plugins/lists/common/schemas/request/create_exception_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import {
   CreateExceptionListSchema,

x-pack/plugins/lists/common/schemas/request/create_exception_list_schema.ts

@@ -25,7 +25,7 @@ import {
   DefaultUuid,
   DefaultVersionNumber,
   DefaultVersionNumberDecoded,
-} from '../../siem_common_deps';
+} from '../../shared_imports';
 import { NamespaceType } from '../types';
 
 export const createExceptionListSchema = t.intersection([

x-pack/plugins/lists/common/schemas/request/create_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getCreateListItemSchemaMock } from './create_list_item_schema.mock';
 import { CreateListItemSchema, createListItemSchema } from './create_list_item_schema';

x-pack/plugins/lists/common/schemas/request/create_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { CreateListSchema, createListSchema } from './create_list_schema';
 import { getCreateListSchemaMock } from './create_list_schema.mock';

x-pack/plugins/lists/common/schemas/request/create_list_schema.ts

@@ -8,7 +8,7 @@ import * as t from 'io-ts';
 
 import { description, deserializer, id, meta, name, serializer, type } from '../common/schemas';
 import { RequiredKeepUndefined } from '../../types';
-import { DefaultVersionNumber, DefaultVersionNumberDecoded } from '../../siem_common_deps';
+import { DefaultVersionNumber, DefaultVersionNumberDecoded } from '../../shared_imports';
 
 export const createListSchema = t.intersection([
   t.exact(

x-pack/plugins/lists/common/schemas/request/delete_endpoint_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import {
   DeleteEndpointListItemSchema,

x-pack/plugins/lists/common/schemas/request/delete_exception_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import {
   DeleteExceptionListItemSchema,

x-pack/plugins/lists/common/schemas/request/delete_exception_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import {
   DeleteExceptionListSchema,

x-pack/plugins/lists/common/schemas/request/delete_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { DeleteListItemSchema, deleteListItemSchema } from './delete_list_item_schema';
 import { getDeleteListItemSchemaMock } from './delete_list_item_schema.mock';

x-pack/plugins/lists/common/schemas/request/delete_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { DeleteListSchema, deleteListSchema } from './delete_list_schema';
 import { getDeleteListSchemaMock } from './delete_list_schema.mock';

x-pack/plugins/lists/common/schemas/request/export_list_item_query_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import {
   ExportListItemQuerySchema,

x-pack/plugins/lists/common/schemas/request/find_endpoint_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import {
   getFindEndpointListItemSchemaDecodedMock,

x-pack/plugins/lists/common/schemas/request/find_exception_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 import { LIST_ID } from '../../constants.mock';
 
 import {

x-pack/plugins/lists/common/schemas/request/find_exception_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import {
   getFindExceptionListSchemaDecodedMock,

x-pack/plugins/lists/common/schemas/request/find_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 import { LIST_ID } from '../../constants.mock';
 
 import {

x-pack/plugins/lists/common/schemas/request/find_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getFindListSchemaDecodedMock, getFindListSchemaMock } from './find_list_schema.mock';
 import { FindListSchemaEncoded, findListSchema } from './find_list_schema';

x-pack/plugins/lists/common/schemas/request/import_list_item_query_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import {
   ImportListItemQuerySchema,

x-pack/plugins/lists/common/schemas/request/import_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { ImportListItemSchema, importListItemSchema } from './import_list_item_schema';
 import { getImportListItemSchemaMock } from './import_list_item_schema.mock';

x-pack/plugins/lists/common/schemas/request/patch_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getPathListItemSchemaMock } from './patch_list_item_schema.mock';
 import { PatchListItemSchema, patchListItemSchema } from './patch_list_item_schema';

x-pack/plugins/lists/common/schemas/request/patch_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getPathListSchemaMock } from './patch_list_schema.mock';
 import { PatchListSchema, patchListSchema } from './patch_list_schema';

x-pack/plugins/lists/common/schemas/request/read_endpoint_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getReadEndpointListItemSchemaMock } from './read_endpoint_list_item_schema.mock';
 import {

x-pack/plugins/lists/common/schemas/request/read_exception_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getReadExceptionListItemSchemaMock } from './read_exception_list_item_schema.mock';
 import {

x-pack/plugins/lists/common/schemas/request/read_exception_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getReadExceptionListSchemaMock } from './read_exception_list_schema.mock';
 import { ReadExceptionListSchema, readExceptionListSchema } from './read_exception_list_schema';

x-pack/plugins/lists/common/schemas/request/read_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getReadListItemSchemaMock } from './read_list_item_schema.mock';
 import { ReadListItemSchema, readListItemSchema } from './read_list_item_schema';

x-pack/plugins/lists/common/schemas/request/read_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getReadListSchemaMock } from './read_list_schema.mock';
 import { ReadListSchema, readListSchema } from './read_list_schema';

x-pack/plugins/lists/common/schemas/request/update_endpoint_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import {
   UpdateEndpointListItemSchema,

x-pack/plugins/lists/common/schemas/request/update_exception_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import {
   UpdateExceptionListItemSchema,

x-pack/plugins/lists/common/schemas/request/update_exception_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import {
   UpdateExceptionListSchema,

x-pack/plugins/lists/common/schemas/request/update_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { UpdateListItemSchema, updateListItemSchema } from './update_list_item_schema';
 import { getUpdateListItemSchemaMock } from './update_list_item_schema.mock';

x-pack/plugins/lists/common/schemas/response/acknowledge_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getAcknowledgeSchemaResponseMock } from './acknowledge_schema.mock';
 import { AcknowledgeSchema, acknowledgeSchema } from './acknowledge_schema';

x-pack/plugins/lists/common/schemas/response/create_endpoint_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getExceptionListSchemaMock } from './exception_list_schema.mock';
 import { CreateEndpointListSchema, createEndpointListSchema } from './create_endpoint_list_schema';

x-pack/plugins/lists/common/schemas/response/exception_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getExceptionListItemSchemaMock } from './exception_list_item_schema.mock';
 import { ExceptionListItemSchema, exceptionListItemSchema } from './exception_list_item_schema';

x-pack/plugins/lists/common/schemas/response/exception_list_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getExceptionListSchemaMock } from './exception_list_schema.mock';
 import { ExceptionListSchema, exceptionListSchema } from './exception_list_schema';

x-pack/plugins/lists/common/schemas/response/found_exception_list_item_schema.test.ts

@@ -7,7 +7,7 @@
 import { left } from 'fp-ts/lib/Either';
 import { pipe } from 'fp-ts/lib/pipeable';
 
-import { exactCheck, foldLeftRight, getPaths } from '../../siem_common_deps';
+import { exactCheck, foldLeftRight, getPaths } from '../../shared_imports';
 
 import { getExceptionListItemSchemaMock } from './exception_list_item_schema.mock';
 import { getFoundExceptionListItemSchemaMock } from './found_exception_list_item_schema.mock';