会費ページのフロントを作成 #98
Open
会費ページのフロントを作成 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
createUsers.tsのところでエラーが出てるみたいなので、見直してみてほしいです！ |
nyatinte
reviewed
Sep 4, 2022
There was a problem hiding this comment.
@0514kento
レビューしました！
@YutaUra
あまりレビュー慣れていないんですけど、こんな感じで大丈夫ですか？
GitHub – Pull Requestをレビュー【コメントの書き方と修正 ...https://howpon.com › IT・デジタル
これ参考にしました
| @@ -1,16 +1,34 @@ | |||
| import { DefaultLayout } from '../components/DefaultLayout' | |||
| import { Text, Box, Heading, Flex } from '@chakra-ui/react' | |||
| import Image from 'next/image' | |||
| import Pay from '../assets/images/pay.jpg' | |||
There was a problem hiding this comment.
Payという命名だと少し意味が分かりにくいように感じました。
PaidIconのような名前だと個人的には分かりやすいです！
| <Flex direction={{ base: 'column', md: 'row' }} gap={5}> | ||
| <Box background="#fff" borderRadius="3xl" flex={1} p={5}> | ||
| <Flex direction={{ base: 'column', md: 'row' }} gap={5} padding={10}> | ||
| <Box background="#fff" borderRadius="3xl" flex={2} p={5}> |
There was a problem hiding this comment.
<Box background="#fff" ...>となっていますが、chakrauiでは短縮されたpropsが用意されています。
<Box bg="white" ...>のように書くとchakraっぽくていいと思います
| <Heading textAlign="center">支払い状況</Heading> | ||
|
|
||
| <Image src={Pay} /> |
There was a problem hiding this comment.
画像サイズが大きすぎると思います
このようなページは1画面上で全て情報が完結することが望ましいと思うのでboxSizepropsなどで少しサイズを変更するとさらに良くなると思います。
YutaUra
reviewed
Sep 4, 2022
nyatinte
reviewed
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webページぽくなってきたので、どなたかアドバイスお願いしたいです。