feat(engine): added main engine mvp #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UrbanoFonseca
force-pushed
the
feat/prime-engine
branch
from
1ee36c6 to
87c3d41
Compare
jfsantos-ds
reviewed
Jul 16, 2021
jfsantos-ds
reviewed
Jul 16, 2021
jfsantos-ds
reviewed
Jul 16, 2021
jfsantos-ds
reviewed
Jul 16, 2021
jfsantos-ds
reviewed
Jul 16, 2021
There was a problem hiding this comment.
Looking good, happy to see it going through the notebook test with apparently no trouble!
There are probably still some compatibility issues depending on the provided arguments.
Integration can probably still go a long way (mitigating duplicated resources/tasks) but we are getting there 🙌🏼
added 6 commits
July 25, 2021 21:51
UrbanoFonseca
force-pushed
the
feat/prime-engine
branch
from
1ddf57a to
c1277cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the core DataQuality engine that dispatches and stores results from the multiple individual engines.
Features:
Closes #6