Skip to content

Commit

Permalink
review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Dmitry Razumov committed Oct 14, 2024
1 parent fb43497 commit f8abf52
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cloud/filestore/config/diagnostics.proto
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ message TDiagnosticsConfig
optional TMonitoringUrlData MonitoringUrlData = 22;

// Report histogram as a set of manually created counters
optional bool ReportHistogramAsMultipleCounters = 23;
optional bool ReportHistogramAsMultipleCounters = 24;

// Report histogram as a single counter (THistogramCounter)
optional bool ReportHistogramAsSingleCounter = 24;
optional bool ReportHistogramAsSingleCounter = 25;
}
6 changes: 3 additions & 3 deletions cloud/storage/core/libs/diagnostics/request_counters.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ struct THistBase
THistogramPtr Hist;
std::array<TDynamicCounters::TCounterPtr, TDerived::BUCKETS_COUNT> Counters;

explicit THistBase(EHistogramCounterOptions counterOptions = {})
explicit THistBase(EHistogramCounterOptions counterOptions)
: HistBounds(ConvertToHistBounds(TDerived::Buckets))
, CounterOptions(counterOptions)
, Hist(
Expand Down Expand Up @@ -296,8 +296,8 @@ struct TRequestCounters::TStatCounters
TAtomic FullyInitialized = false;

explicit TStatCounters(
ITimerPtr timer,
EHistogramCounterOptions histogramCounterOptions)
ITimerPtr timer,
EHistogramCounterOptions histogramCounterOptions)
: SizeHist(histogramCounterOptions)
, TimeHist(histogramCounterOptions)
, TimeHistUnaligned(histogramCounterOptions)
Expand Down

0 comments on commit f8abf52

Please sign in to comment.