Resize the shadow disk when the size of the source disk changes #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbasic
added
the
blockstore
qkrorlqr
previously approved these changes
Sep 27, 2024
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 708e055.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 708e055.
|
komarevtsev-d
approved these changes
Sep 30, 2024
qkrorlqr
approved these changes
Sep 30, 2024
drbasic
added a commit
that referenced
this pull request
Oct 1, 2024
* Resize the shadow disk when the size of the source disk changes * Rename method
drbasic
added a commit
that referenced
this pull request
Oct 2, 2024
* Handle migration partition non-retriable errors separately (#2142) * Handle migration partition non-retriable errors separately * Tests * Fix review issues * fixed use-after-free in partition_nonrepl uts (#2184) * Fix wrong response type usage (#2150) * Resize the shadow disk when the size of the source disk changes (#2152) * Resize the shadow disk when the size of the source disk changes * Rename method --------- Co-authored-by: Andrei Strelkovskii <thinkingwhat@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Когда происходит изменение диска нужно изменить и размер теневого диска тоже, чтобы если в этот момент идет миграция, то записи пользователей могли проходить, а не падать с ошибкой E_ARGUMENT, что приводит к поломке NRD и залипанию mirror-диска.
Т.е. фикс чинит проблему, когда пользователь изменил размер диска в процессе создания снимка.