configure rdma target thread pool size; issue-2267 #2268
Conversation
also clean up TRdmaTarget interface and unnest Host and Port fields in TRdmaTargetProto
| TRdmaServer Server = 2; // deprecated | ||
| string Host = 3; | ||
| uint32 Port = 4; | ||
| uint32 Threads = 5; |
There was a problem hiding this comment.
Let's have all rdma related config in rdma.txt file which has the TRdmaConfig message serialized to it.
This TRdmaTarget message is actually deprecated and we should not extend it. I left it since the old config was using it here. But the idea was to move all required params to the TRdmaConfig struct.
So in you PR let's just add the RdmaServerNumHandlerThreads (I think it's better then just Threads since we might have some other threads we want to configure) to the TRdmaConfig.
And we need to pass this config to the rdmaTargetConfig here by getting it from RdmaConfig that already present in the disk agent actor.
Also let's not refactor the host/port in this PR. I noticed that the port is still coming from disk-agent.txt config
here
So either we leave it in the NProto::TDiskAgentConfig or move it to the rdma.txt as well. I will be easier to understand if it will be a separate PR
also clean up TRdmaTarget interface and unnest Host and Port fields in TRdmaTargetProto