Introduce local hdd disks #2291
Draft
+115
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komarevtsev-d
force-pushed
the
users/komarevtsev-d/local-hdd/0
branch
from
c58b4cd
to
b1f6e1e
Compare
drbasic
reviewed
Oct 16, 2024
| @@ -348,7 +348,10 @@ void TServiceActor::RenderVolumeList(IOutputStream& out) const | |||
| } | |||
| TABLED() { | |||
| if (volume.GetLocalMountClientInfo() && | |||
| volume.StorageMediaKind != NProto::STORAGE_MEDIA_SSD_LOCAL) | |||
| volume.StorageMediaKind != | |||
There was a problem hiding this comment.
может какую-нить утилитную функцию сделать IsLocalMediaKind(...) ?
| @@ -178,6 +178,7 @@ class TRequestStats final | |||
| TRequestCounters TotalSSDMirror3; | |||
| TRequestCounters TotalSSDLocal; | |||
| TRequestCounters TotalHDDNonrepl; | |||
| TRequestCounters TotalHDDLocal; | |||
There was a problem hiding this comment.
я бы это по-ближе к TotalSSDLocal поместил
|
|
||
| ui64 hddCount = RunCounters[NCloud::NProto::STORAGE_MEDIA_DEFAULT] + | ||
| RunCounters[NCloud::NProto::STORAGE_MEDIA_HYBRID] + | ||
| RunCounters[NCloud::NProto::STORAGE_MEDIA_HDD]; |
| if (!NProto::EStorageMediaKind_IsValid(volume.GetStorageMediaKind())) { | ||
| auto response = | ||
| std::make_unique<TEvDiskRegistry::TEvCreateDiskFromDevicesResponse>( | ||
| std::move(MakeError( |
| @@ -96,6 +96,9 @@ void TStatsServiceActor::UpdateVolumeSelfCounters(const TActorContext& ctx) | |||
| &State.GetSsdMirror3Counters(), | |||
| &State.GetSsdSystemCounters(), | |||
| &State.GetHddSystemCounters(), | |||
| &State.GetHddSystemCounters(), | |||
There was a problem hiding this comment.
&State.GetHddSystemCounters(), два раза
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.