Skip to content

Commit

Permalink
fixed issues 2
Browse files Browse the repository at this point in the history
  • Loading branch information
evanevanevanevannnn committed Sep 10, 2024
1 parent d67ff23 commit d1d1078
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions ydb/tests/fq/s3/test_s3_0.py
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@ def test_bad_format(self, kikimr, s3, client, runtime_listing, unique_prefix):

@yq_v2
@pytest.mark.parametrize("client", [{"folder_id": "my_folder"}], indirect=True)
def bad_request_on_invalid_json(self, kikimr, s3, client, unique_prefix):
def test_bad_request_on_invalid_parquet(self, kikimr, s3, client, unique_prefix):
resource = boto3.resource(
"s3", endpoint_url=s3.s3_url, aws_access_key_id="key", aws_secret_access_key="secret_key"
)
Expand All @@ -765,21 +765,22 @@ def bad_request_on_invalid_json(self, kikimr, s3, client, unique_prefix):
"s3", endpoint_url=s3.s3_url, aws_access_key_id="key", aws_secret_access_key="secret_key"
)

s3_client.put_object(Body="blah blah blah", Bucket='bbucket', Key='file.json', ContentType='text/plain')

s3_client.put_object(Body='not a parquet file', Bucket='bbucket', Key='file.txt', ContentType='text/plain')

kikimr.control_plane.wait_bootstrap(1)
storage_connection_name = unique_prefix + "badbucket"
client.create_storage_connection(storage_connection_name, "bbucket")

sql = f'''
select * from `{storage_connection_name}`.`file.json` with (format=parquet, schema (data string));
select * from `{storage_connection_name}`.`file.txt` with (format=parquet, schema (data string));
'''

query_id = client.create_query("simple", sql, type=fq.QueryContent.QueryType.ANALYTICS).result.query_id
client.wait_query_status(query_id, fq.QueryMeta.FAILED)
assert "Query failed with code BAD_REQUEST" in str(
client.describe_query(query_id).result
)

error_message = str(client.describe_query(query_id).result)
assert ("Query failed with code BAD_REQUEST" in error_message) and ("Parquet magic bytes not found in footer." in error_message)

@yq_v1
@pytest.mark.parametrize("client", [{"folder_id": "my_folder"}], indirect=True)
Expand Down

0 comments on commit d1d1078

Please sign in to comment.