Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataShard: table merge and borrowed compaction race #3154

Closed
snaury opened this issue Mar 26, 2024 · 0 comments · Fixed by #3164
Closed

DataShard: table merge and borrowed compaction race #3154

snaury opened this issue Mar 26, 2024 · 0 comments · Fixed by #3164
Assignees
@snaury
Labels
bug Something isn't working

Comments

@snaury
Copy link
Member

snaury commented Mar 26, 2024 •
edited
Loading

Turns out #2286 introduced a race, when datashard allows local database to compact borrowed data before all borrowed data is actually loaded and merged into the table. This may cause local database compaction to later fail due to unexpected epoch invariant violations.
@snaury snaury added the bug Something isn't working label Mar 26, 2024
@snaury snaury self-assigned this Mar 26, 2024
snaury added a commit to snaury/ydb that referenced this issue Mar 26, 2024
@snaury
Fix race between table merge and borrowed gc compaction. Fixes ydb-pl…
fccde72 
…atform#3154.
@snaury snaury mentioned this issue Mar 26, 2024
Merged
snaury added a commit to snaury/ydb that referenced this issue Mar 26, 2024
@snaury
Fix race between table merge and borrowed gc compaction. Fixes ydb-pl…
321a089 
…atform#3154.
@snaury snaury mentioned this issue Mar 26, 2024
Merged
snaury added a commit that referenced this issue Mar 26, 2024
@snaury
Fix race between table merge and borrowed gc compaction. Fixes #3154. (…
7d3baf9 
…#3164)
snaury added a commit that referenced this issue Mar 26, 2024
@snaury
24-1: Fix race between table merge and borrowed gc compaction. Fixes #…
6fbfd4a 
…3154. (#3165)
This was referenced Mar 29, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this issue Apr 2, 2024
Merged
@serbel324 serbel324 mentioned this issue Apr 2, 2024
Merged
This was referenced Apr 4, 2024
Merged
Merged
Merged
@shnikd shnikd mentioned this issue Apr 4, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this issue Apr 4, 2024
Open
This was referenced Apr 6, 2024
Merged
Merged
Closed
SammyVimes pushed a commit to SammyVimes/ydb that referenced this issue Apr 9, 2024
@snaury @SammyVimes
24-1: Fix race between table merge and borrowed gc compaction. Fixes y…
f80bf10 
…db-platform#3154. (ydb-platform#3165)
@StekPerepolnen StekPerepolnen mentioned this issue Apr 10, 2024
Merged
@shnikd shnikd mentioned this issue Apr 11, 2024
Merged
This was referenced Apr 16, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this issue Apr 24, 2024
Closed
@serbel324 serbel324 mentioned this issue Apr 25, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this issue Apr 26, 2024
Closed
@mregrock mregrock mentioned this issue May 15, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this issue May 24, 2024
Closed
This was referenced Jun 7, 2024
Closed
Closed
@CyberROFL CyberROFL mentioned this issue Jun 19, 2024
Closed
@CyberROFL CyberROFL mentioned this issue Jul 12, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this issue Jul 15, 2024
Closed
@CyberROFL CyberROFL mentioned this issue Jul 30, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this issue Aug 23, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this issue Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snaury snaury

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@snaury