Skip to content

Conversation

@adameat
Copy link
Member

@adameat adameat commented Oct 4, 2024

Changelog entry

add url params to trace attributes

Changelog category

  • Improvement
  • Not for changelog (changelog entry is not required)

@adameat adameat requested a review from a team as a code owner October 4, 2024 06:46
@adameat adameat enabled auto-merge (squash) October 4, 2024 06:46
@github-actions
Copy link

github-actions bot commented Oct 4, 2024

2024-10-04 06:48:53 UTC Pre-commit check linux-x86_64-release-asan for 772d907 has started.
2024-10-04 06:49:04 UTC Artifacts will be uploaded here
2024-10-04 06:51:53 UTC ya make is running...
🟡 2024-10-04 08:17:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10104 9726 0 61 277 40

🟢 2024-10-04 08:18:23 UTC Build successful.
🟢 2024-10-04 08:19:13 UTC ydbd size 5.7 GiB changed* by -3.9 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 595af5f merge: 772d907 diff diff %
ydbd size 6 086 289 376 Bytes 6 082 226 344 Bytes -3.9 MiB -0.067%
ydbd stripped size 1 520 590 960 Bytes 1 519 836 528 Bytes -736.8 KiB -0.050%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 4, 2024

2024-10-04 06:50:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 772d907 has started.
2024-10-04 06:50:33 UTC Artifacts will be uploaded here
2024-10-04 06:53:24 UTC ya make is running...
🟢 2024-10-04 07:39:15 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14865 13385 0 0 1379 101

🟢 2024-10-04 07:40:26 UTC Build successful.
🟢 2024-10-04 07:40:44 UTC ydbd size 2.8 GiB changed* by -609.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 595af5f merge: 772d907 diff diff %
ydbd size 3 001 837 456 Bytes 3 001 213 032 Bytes -609.8 KiB -0.021%
ydbd stripped size 477 361 080 Bytes 477 266 360 Bytes -92.5 KiB -0.020%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit b83b572 into ydb-platform:main Oct 4, 2024
@adameat adameat deleted the add-url-to-trace-parameters branch October 4, 2024 09:27
adameat added a commit to adameat/ydb that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants