YQ-2630: fix and support detalization for v1 #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-release-asan: some tests FAILED for commit da0a6a6.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit da0a6a6.
|
Hor911
reviewed
Jan 17, 2024
| namespace { | ||
|
|
||
| const NJson::TJsonValue* GetStatisticsRoot(const NJson::TJsonValue& allStatistics) { | ||
| const NJson::TJsonValue* GetStatisticsRoot(const NJson::TJsonValue& allStatistics, std::string_view v1Pointer = "Graph=0") { |
Collaborator
There was a problem hiding this comment.
Both kind of statistics may include multiple graphs. To get correct stats it is needed to enumerate all of them and summarize total value
v1 graph will have root with name starting from
- Graph=
- Precompute=
v2 graph will have root with name starting from
- ResultSet
- Precompute
- Sink
v2 names may have no suffixes or suffixes like "_0", so Precompute can be distinguished from v1 by "=" symbol
dorooleg
approved these changes
Jan 18, 2024
dorooleg
pushed a commit
to dorooleg/ydb
that referenced
this pull request
Jan 18, 2024
* also support multiple graphs, move test data to resources
EgorkaZ
added a commit
to EgorkaZ/ydb
that referenced
this pull request
Jan 19, 2024
* also support multiple graphs, move test data to resources
EgorkaZ
added a commit
that referenced
this pull request
Jan 19, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
This was referenced Jan 29, 2024
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 6, 2024
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.