Skip to content

Conversation

@rvu1024
Copy link
Member

@rvu1024 rvu1024 commented Jan 17, 2024

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 17, 2024

2024-01-17 17:04:11 UTC Pre-commit check for 22b06f0 has started.
2024-01-17 17:04:14 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-17 17:06:52 UTC Build successful.
2024-01-17 17:07:08 UTC Tests are running...
🔴 2024-01-17 18:45:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59942 50705 0 5 9219 13

@github-actions
Copy link

github-actions bot commented Jan 17, 2024

2024-01-17 17:06:22 UTC Pre-commit check for 22b06f0 has started.
2024-01-17 17:06:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-17 17:08:38 UTC Build successful.
2024-01-17 17:08:53 UTC Tests are running...
🔴 2024-01-17 18:51:20 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15903 15807 0 37 47 12

@rvu1024 rvu1024 marked this pull request as ready for review January 18, 2024 09:47
@rvu1024 rvu1024 requested review from vitstn and zverevgeny January 18, 2024 09:47
@zverevgeny
Copy link
Collaborator

Such approach will bloat client's executables. IMHO it's better to specify required public symbols in the linker script

@rvu1024 rvu1024 merged commit dc73153 into ydb-platform:main Jan 18, 2024
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Jan 18, 2024
@rvu1024 rvu1024 deleted the fix-make branch January 22, 2024 09:50
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
@vitstn vitstn mentioned this pull request Jan 29, 2024
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants