Support CollectDiagnostics in DATA_QUERY/GENERIC_QUERY #11371
Conversation
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
shnikd
force-pushed
the
collect-full-diagnostics
branch
from
4f19586 to
2ce9291
Compare
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -43,6 +44,8 @@ void TCommandSql::Config(TConfig& config) { | |||
| config.Opts->AddLongOption("syntax", "Query syntax [yql, pg]") | |||
| .RequiredArgument("[String]").DefaultValue("yql").StoreResult(&Syntax) | |||
| .Hidden(); | |||
| config.Opts->AddLongOption("collect-diagnostics", "Collects diagnostics and saves it to file") | |||
There was a problem hiding this comment.
А новая опция прошла саппорт?
| @@ -235,6 +245,11 @@ int TCommandSql::PrintResponse(NQuery::TExecuteQueryIterator& result) { | |||
| queryPlanPrinter.Print(*plan); | |||
| } | |||
|
|
|||
| if (CollectFullDiagnostics) { | |||
| TFileOutput file(TStringBuilder() << "diagnostics_" << TGUID::Create().AsGuidString() << ".txt"); | |||
There was a problem hiding this comment.
А почему диагностику грузим в рандомный файл? Не лучше дать пользователю дать возможность указать путь до файла?
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ |
|
⚪ |
| @@ -942,7 +942,6 @@ message ExecuteDataQueryRequest { | |||
| QueryCachePolicy query_cache_policy = 5; | |||
| Ydb.Operations.OperationParams operation_params = 6; | |||
| QueryStatsCollection.Mode collect_stats = 7; | |||
| bool collect_full_diagnostics = 8; | |||
There was a problem hiding this comment.
А как тут обеспечится обратная совместимость для клиентов?
|
⚪ |
|
⚪ |
No description provided.