Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQ-3846 RD support OR split during pushdown #11439

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Nov 10, 2024

Changelog entry

Supported OR split during pushdown.

For example if we have predicate in WHERE:

(A_1 AND A_2) OR (B_1 AND B_2) OR ...

We can pushdown only:

A_1 OR B_1 OR ...

In case of unsupported or too complicated A_2 and B_2

Changelog category

  • Improvement

Additional information

Copy link

github-actions bot commented Nov 10, 2024

2024-11-10 06:05:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for bd84563 has started.
2024-11-10 06:05:21 UTC Artifacts will be uploaded here
2024-11-10 06:06:03 UTC Check cancelled

Copy link

github-actions bot commented Nov 10, 2024

2024-11-10 06:09:59 UTC Pre-commit check linux-x86_64-release-asan for dfaa0c9 has started.
2024-11-10 06:10:10 UTC Artifacts will be uploaded here
2024-11-10 06:13:11 UTC ya make is running...
🟡 2024-11-10 07:18:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8971 8911 0 19 9 32

🟢 2024-11-10 07:19:17 UTC Build successful.
🟢 2024-11-10 07:19:47 UTC ydbd size 5.7 GiB changed* by +73.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 13fb53d merge: dfaa0c9 diff diff %
ydbd size 6 165 945 216 Bytes 6 166 020 464 Bytes +73.5 KiB +0.001%
ydbd stripped size 1 537 510 032 Bytes 1 537 517 008 Bytes +6.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 10, 2024

2024-11-10 06:10:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for dfaa0c9 has started.
2024-11-10 06:10:25 UTC Artifacts will be uploaded here
2024-11-10 06:13:27 UTC ya make is running...
🟡 2024-11-10 07:08:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40119 34415 0 8 5586 110

2024-11-10 07:11:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-10 07:22:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
145 (only retried tests) 46 0 0 1 98

🟢 2024-11-10 07:22:54 UTC Build successful.
🟢 2024-11-10 07:23:15 UTC ydbd size 2.8 GiB changed* by +27.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 13fb53d merge: dfaa0c9 diff diff %
ydbd size 3 046 779 416 Bytes 3 046 807 736 Bytes +27.7 KiB +0.001%
ydbd stripped size 482 228 056 Bytes 482 229 336 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 10, 2024

2024-11-10 07:42:27 UTC Pre-commit check linux-x86_64-release-asan for dd5bcad has started.
2024-11-10 07:42:39 UTC Artifacts will be uploaded here
2024-11-10 07:45:39 UTC ya make is running...
🟡 2024-11-10 08:49:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8971 8904 0 24 7 36

🟢 2024-11-10 08:50:14 UTC Build successful.
🟢 2024-11-10 08:50:45 UTC ydbd size 5.7 GiB changed* by +73.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 13fb53d merge: dd5bcad diff diff %
ydbd size 6 165 945 216 Bytes 6 166 020 464 Bytes +73.5 KiB +0.001%
ydbd stripped size 1 537 510 032 Bytes 1 537 517 008 Bytes +6.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 10, 2024

2024-11-10 07:42:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for dd5bcad has started.
2024-11-10 07:42:59 UTC Artifacts will be uploaded here
2024-11-10 07:46:02 UTC ya make is running...
🟡 2024-11-10 08:41:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40117 34461 0 1 5557 98

2024-11-10 08:44:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-10 08:55:56 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 3 0 0 0 95

🟢 2024-11-10 08:56:03 UTC Build successful.
🟢 2024-11-10 08:56:21 UTC ydbd size 2.8 GiB changed* by +27.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 13fb53d merge: dd5bcad diff diff %
ydbd size 3 046 779 416 Bytes 3 046 807 736 Bytes +27.7 KiB +0.001%
ydbd stripped size 482 228 056 Bytes 482 229 336 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA requested a review from uzhastik November 10, 2024 19:19
Copy link

github-actions bot commented Nov 10, 2024

2024-11-10 19:22:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6196fdb has started.
2024-11-10 19:22:24 UTC Artifacts will be uploaded here
2024-11-10 19:25:26 UTC ya make is running...
🟡 2024-11-10 20:18:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40126 34462 0 1 5560 103

2024-11-10 20:21:56 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-10 20:33:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 9 0 0 0 96

🟢 2024-11-10 20:33:53 UTC Build successful.
🟢 2024-11-10 20:34:12 UTC ydbd size 2.8 GiB changed* by +27.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e2103f9 merge: 6196fdb diff diff %
ydbd size 3 046 849 368 Bytes 3 046 877 664 Bytes +27.6 KiB +0.001%
ydbd stripped size 482 233 752 Bytes 482 235 032 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 10, 2024

2024-11-10 19:22:19 UTC Pre-commit check linux-x86_64-release-asan for 6196fdb has started.
2024-11-10 19:22:30 UTC Artifacts will be uploaded here
2024-11-10 19:25:30 UTC ya make is running...
🟡 2024-11-10 20:29:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8975 8904 0 28 9 34

🟢 2024-11-10 20:29:49 UTC Build successful.
🟢 2024-11-10 20:30:19 UTC ydbd size 5.7 GiB changed* by +77.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e2103f9 merge: 6196fdb diff diff %
ydbd size 6 166 084 424 Bytes 6 166 163 768 Bytes +77.5 KiB +0.001%
ydbd stripped size 1 537 528 656 Bytes 1 537 539 728 Bytes +10.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit e31118f into ydb-platform:main Nov 11, 2024
10 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3846-RD-support-OR-split-during-pushdown branch November 11, 2024 14:15
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants