Check types for pushdown on OLAP level. #1144

Tony-Romanov · 2024-01-18T21:34:50Z

No description provided.

github-actions · 2024-01-19T07:57:50Z

⚪ 2024-01-19 10:34:12 UTC Pre-commit check for a8e14a9 has started.
⚪ 2024-01-19 10:34:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-19 10:36:17 UTC Build successful.
⚪ 2024-01-19 10:36:30 UTC Tests are running...
🔴 2024-01-19 10:46:33 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
59998	50761	0	2	9227	8

github-actions · 2024-01-19T07:58:01Z

⚪ 2024-01-19 10:34:14 UTC Pre-commit check for a8e14a9 has started.
⚪ 2024-01-19 10:34:17 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-19 10:36:21 UTC Build successful.
⚪ 2024-01-19 10:36:34 UTC Tests are running...
🔴 2024-01-19 10:42:30 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15895	15811	0	17	59	8

Darych

LGTM. Let's wait for Vasiliy.

UgnineSirdis · 2024-01-24T12:23:42Z

ydb/core/kqp/opt/physical/kqp_opt_phy_olap_filter.cpp

+        case ETypeAnnotationKind::Data: {
+            const auto fOne = NUdf::GetDataTypeInfo(rawOne.Cast<TDataExprType>()->GetSlot()).Features;
+            const auto fTwo = NUdf::GetDataTypeInfo(rawTwo.Cast<TDataExprType>()->GetSlot()).Features;
+            return ((NUdf::EDataTypeFeatures::NumericType | NUdf::EDataTypeFeatures::StringType) & fOne) && (NUdf::EDataTypeFeatures::CanCompare  & fOne)


Here are two spaces before &

UgnineSirdis · 2024-01-24T12:23:49Z

ydb/core/kqp/opt/physical/kqp_opt_phy_olap_filter.cpp

+            const auto fOne = NUdf::GetDataTypeInfo(rawOne.Cast<TDataExprType>()->GetSlot()).Features;
+            const auto fTwo = NUdf::GetDataTypeInfo(rawTwo.Cast<TDataExprType>()->GetSlot()).Features;
+            return ((NUdf::EDataTypeFeatures::NumericType | NUdf::EDataTypeFeatures::StringType) & fOne) && (NUdf::EDataTypeFeatures::CanCompare  & fOne)
+                && ((NUdf::EDataTypeFeatures::NumericType | NUdf::EDataTypeFeatures::StringType) & fTwo) && (NUdf::EDataTypeFeatures::CanCompare  & fTwo);


Here are two spaces before &

Tony-Romanov and others added 2 commits January 18, 2024 22:26

Check types for pushdown on OLAP level.

938538d

Merge branch 'ydb-platform:main' into fix_comparators_in_olap

d85faa0

Update test.

a8e14a9

Tony-Romanov requested a review from UgnineSirdis January 19, 2024 10:56

Tony-Romanov marked this pull request as ready for review January 19, 2024 10:56

Tony-Romanov requested a review from pavelvelikhov January 19, 2024 16:15

Darych approved these changes Jan 23, 2024

View reviewed changes

Tony-Romanov merged commit de0a267 into ydb-platform:main Jan 23, 2024

Tony-Romanov deleted the fix_comparators_in_olap branch January 23, 2024 18:11

pavelvelikhov mentioned this pull request Jan 24, 2024

Fixed a minor bug in simplified plan JSON generation #1257

Merged

UgnineSirdis reviewed Jan 24, 2024

View reviewed changes

FloatingCrowbar mentioned this pull request Jan 24, 2024

Fix args order bug #1280

Merged

niksaveliev mentioned this pull request Jan 25, 2024

Fix kafka metadata actor for Topics.size() == 0 and fix read by short topic name #1287

Merged

vitstn mentioned this pull request Jan 25, 2024

validate & lineage modes in dqrun #1290

Merged

aakulaga-ydb mentioned this pull request Jan 25, 2024

JsonDocument support added YQL-17658 #1306

Merged

This was referenced Jan 25, 2024

YQL-17418 Support of Merge in lineage #1307

Merged

Fix windows build for invoke_builtins/no_llvm #1315

Merged

YQL-17264 static part of tables #1327

Merged

YQL-17678 throw exception instead of abort #1348

Merged

YQL-17264 static part of columns #1354

Merged

niksaveliev mentioned this pull request Jan 29, 2024

Kafka Connect docs #1369

Merged

vitstn mentioned this pull request Jan 29, 2024

fix mkql warnings #1375

Merged

shnikd mentioned this pull request Jan 29, 2024

KIKIMR-20082: TableStore/ColumnTable with QueryService #1377

Merged

This was referenced Jan 29, 2024

fix warnings for pg_wrapper #1383

Merged

fix sql2yql warnings #1394

Merged

fix pg sql warnings #1395

Merged

YQL-17343 information_schema.table_constraints #1397

Merged

ildar-khisambeev mentioned this pull request Jan 30, 2024

LOGBROKER-8792 remove redundant checks #1417

Merged

shnikd mentioned this pull request Feb 5, 2024

Support temp tables in yql #1589

Merged

This was referenced Feb 5, 2024

YQL-17339 import all columns from real PG #1594

Merged

fix aarch64 compile flags #1598

Merged

niksaveliev mentioned this pull request Feb 5, 2024

Fixes lock partition delay and balance test #1600

Merged

pavelvelikhov mentioned this pull request Feb 5, 2024

Generate single JSON with all types of plans in the server #1606

Merged

vitstn mentioned this pull request Feb 5, 2024

YQL-17476 check for cycle during evaluation of file args #1608

Merged

This was referenced Feb 6, 2024

Fix iterator at kafka connect #1611

Closed

Fix iterator at kafka connect #1612

Merged

This was referenced Feb 6, 2024

parallel for #1650

Merged

YQL-17725 drop b and t suffixes #1660

Merged

YQL-17725 tune doc #1667

Merged

Switch pg_parser BC tests on again #1709

Merged

unmute test #1711

Merged

ildar-khisambeev mentioned this pull request Feb 8, 2024

LOGBROKER-8783 bugfix #1713

Merged

vitstn mentioned this pull request Feb 8, 2024

Mark mutable_id for YT writes #1744

Merged

niksaveliev mentioned this pull request Feb 9, 2024

Fix pq writer and few renames #1757

Merged

pavelvelikhov mentioned this pull request Feb 9, 2024

Cannonized two plans #1773

Merged

niksaveliev mentioned this pull request Feb 12, 2024

Workload read without consumer and metrics fixes #1792

Merged

starlinskiy mentioned this pull request Feb 12, 2024

runtime dispatching #1800

Closed

This was referenced Feb 12, 2024

quick fix for column name of select version() #1801

Merged

Support of database sys cache #1817

Merged

starlinskiy mentioned this pull request Feb 12, 2024

runtime dispatching (fixed) #1847

Merged

pavelvelikhov mentioned this pull request Feb 13, 2024

Fixed a problem with simplified plan JSONs #1878

Merged

This was referenced Feb 13, 2024

Case insensivity for pg_catalog tables/cluster, columns. Support of pg_class:relam, and some columns in pg_database & pg_namespace #1893

Merged

fixed pg_get_userbyid function #1936

Merged

support of AnyNonArray type, fixes for array_agg #1958

Merged

pavelvelikhov mentioned this pull request Feb 15, 2024

Fixed a problem with plans in PG ut #1974

Merged

niksaveliev mentioned this pull request Feb 16, 2024

Fix kafka with enabled proxy #2017

Merged

vitstn mentioned this pull request Feb 16, 2024

mock of savepoints #2026

Merged

aakulaga-ydb mentioned this pull request Feb 24, 2024

Fix TzTimestamp wrong encoding (YQL-17920) #2222

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Check types for pushdown on OLAP level. #1144

Check types for pushdown on OLAP level. #1144

Uh oh!

Tony-Romanov commented Jan 18, 2024

Uh oh!

github-actions bot commented Jan 19, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 19, 2024 •

edited

Loading

Uh oh!

Darych left a comment

Uh oh!

UgnineSirdis Jan 24, 2024

Uh oh!

UgnineSirdis Jan 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Check types for pushdown on OLAP level. #1144

Check types for pushdown on OLAP level. #1144

Uh oh!

Conversation

Tony-Romanov commented Jan 18, 2024

Uh oh!

github-actions bot commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Darych left a comment

Choose a reason for hiding this comment

Uh oh!

UgnineSirdis Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

UgnineSirdis Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jan 19, 2024 •

edited

Loading

github-actions bot commented Jan 19, 2024 •

edited

Loading