Skip to content

Conversation

@azevaykin
Copy link
Collaborator

Changelog entry

A datashard could catch VERIFY during restart with scheme transaction inflight

KIKIMR-22195

Changelog category

  • Bugfix

Additional information

VERIFY failed (2024-11-11T15:00:23.255997+0300):
  contrib/ydb/core/tx/datashard/datashard_pipeline.cpp:49
  Load(): requirement !SchemaTx failed
0. /-S/util/system/yassert.cpp:55: NPrivate::Panic(NPrivate::TStaticBuf const&, int, char const*, char const*, char const*, ...) @ 0x556B236FD67B
1. /-S/contrib/ydb/core/tx/datashard/datashard_pipeline.cpp:49: NKikimr::NDataShard::TPipeline::Load(NKikimr::NIceDb::TNiceDb&) @ 0x556B31C29326
2. /-S/contrib/ydb/core/tx/datashard/datashard__init.cpp:227: NKikimr::NDataShard::TDataShard::TTxInit::ReadEverything(NKikimr::NTabletFlatExecutor::TTransactionContext&) @ 0x556B31D80397
3. /-S/contrib/ydb/core/tx/datashard/datashard__init.cpp:43: NKikimr::NDataShard::TDataShard::TTxInit::Execute(NKikimr::NTabletFlatExecutor::TTransactionContext&, NActors::TActorContext const&) @ 0x556B31D7CDBC
4. /-S/contrib/ydb/core/tablet_flat/flat_executor.cpp:1717: NKikimr::NTabletFlatExecutor::TExecutor::ExecuteTransaction(TAutoPtr<NKikimr::NTabletFlatExecutor::TSeat, TDelete>, NActors::TActorContext const&) @ 0x556B276FF229
5. /-S/contrib/ydb/core/tablet_flat/flat_executor.cpp:2637: NKikimr::NTabletFlatExecutor::TExecutor::Handle(TAutoPtr<NActors::TEventHandle<NKikimr::NTabletFlatExecutor::TExecutor::TEvPrivate::TEvActivateExecution>, TDelete>&, NActors::TActorContext const&) @ 0x556B2770EBFF
6. /-S/contrib/ydb/core/tablet_flat/flat_executor.cpp:3951: NKikimr::NTabletFlatExecutor::TExecutor::StateWork(TAutoPtr<NActors::IEventHandle, TDelete>&) @ 0x556B276E7F1C
7. /-S/contrib/ydb/library/actors/core/executor_thread.cpp:251: NActors::TGenericExecutorThread::TProcessingResult NActors::TGenericExecutorThread::Execute<NActors::TMailboxTable::TReadAsFilledMailbox>(NActors::TMailboxTable::TReadAsFilledMailbox*, unsigned int, bool) @ 0x556B23C8C036
8. /-S/contrib/ydb/library/actors/core/executor_thread.cpp:440: NActors::TGenericExecutorThread::ProcessExecutorPool(NActors::IExecutorPool*)::$_0::operator()(unsigned int, bool) const @ 0x556B23C7EBDE
9. /-S/contrib/ydb/library/actors/core/executor_thread.cpp:492: NActors::TGenericExecutorThread::ProcessExecutorPool(NActors::IExecutorPool*) @ 0x556B23C7E41F
10. /-S/contrib/ydb/library/actors/core/executor_thread.cpp:523: NActors::TExecutorThread::ThreadProc() @ 0x556B23C7F804
11. /-S/util/system/thread.cpp:244: (anonymous namespace)::TPosixThread::ThreadProxy(void*) @ 0x556B2370B859
12. ??:0: ?? @ 0x7FBBE7B20608
13. ??:0: ?? @ 0x7FBBE7A40352

...

@azevaykin azevaykin requested a review from a team as a code owner November 11, 2024 17:00
@github-actions
Copy link

github-actions bot commented Nov 11, 2024

2024-11-11 17:03:56 UTC Pre-commit check for f7e3186 has started.
2024-11-11 17:06:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-11 17:32:07 UTC Build successful.
2024-11-11 17:32:29 UTC Tests are running...
🔴 2024-11-11 19:35:04 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10301 10216 0 19 24 42

🟢 2024-11-11 19:35:51 UTC ydbd size 5.6 GiB changed* by +37.6 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: e3d6f61 merge: f7e3186 diff diff %
ydbd size 5 991 488 696 Bytes 5 991 527 232 Bytes +37.6 KiB +0.001%
ydbd stripped size 1 501 625 216 Bytes 1 501 631 680 Bytes +6.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 11, 2024

2024-11-11 17:03:58 UTC Pre-commit check for f7e3186 has started.
2024-11-11 17:06:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-11 17:48:46 UTC Build successful.
2024-11-11 17:49:02 UTC Tests are running...
🔴 2024-11-11 19:13:33 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14604 13252 0 11 1300 41

🟢 2024-11-11 19:14:23 UTC ydbd size 8.2 GiB changed* by +53.5 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: e3d6f61 merge: f7e3186 diff diff %
ydbd size 8 858 150 736 Bytes 8 858 205 496 Bytes +53.5 KiB +0.001%
ydbd stripped size 483 675 400 Bytes 483 682 504 Bytes +6.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 11, 2024

2024-11-11 17:03:59 UTC Pre-commit check for f7e3186 has started.
2024-11-11 17:07:01 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-11 17:14:52 UTC Build successful.

@azevaykin azevaykin merged commit fcf6826 into ydb-platform:stable-24-3 Nov 12, 2024
8 of 12 checks passed
@azevaykin azevaykin deleted the stable-24-3-pipeline-reset branch November 12, 2024 06:59
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 30, 2024
@azevaykin azevaykin restored the stable-24-3-pipeline-reset branch December 22, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants