Skip to content

Conversation

@azevaykin
Copy link
Collaborator

KIKIMR-7112

Due to an old comparator error there is restriction Keys with Uint8 column values >127 are currently prohibited.
The comparator error has been fixed long ago. So the restriction should be removed.

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@github-actions
Copy link

github-actions bot commented Nov 22, 2024

2024-11-22 12:46:07 UTC Pre-commit check linux-x86_64-release-asan for c7722e1 has started.
2024-11-22 12:46:18 UTC Artifacts will be uploaded here
2024-11-22 12:49:30 UTC ya make is running...
2024-11-22 14:04:15 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Nov 22, 2024

2024-11-22 12:46:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for c7722e1 has started.
2024-11-22 12:46:47 UTC Artifacts will be uploaded here
2024-11-22 12:49:41 UTC ya make is running...
🟡 2024-11-22 13:39:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15515 13992 0 1 1410 112

2024-11-22 13:41:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-22 13:52:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 4 0 1 0 108

2024-11-22 13:53:01 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-11-22 14:04:34 UTC ydbd size 2.5 GiB changed* by -6.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 15c910f merge: c7722e1 diff diff %
ydbd size 2 691 444 608 Bytes 2 691 437 864 Bytes -6.6 KiB -0.000%
ydbd stripped size 482 134 864 Bytes 482 133 264 Bytes -1.6 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-11-22 14:04:35 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Nov 22, 2024

2024-11-22 14:07:40 UTC Pre-commit check linux-x86_64-release-asan for df16974 has started.
2024-11-22 14:07:52 UTC Artifacts will be uploaded here
2024-11-22 14:10:59 UTC ya make is running...
🟡 2024-11-22 15:44:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9088 9018 0 17 6 47

🟢 2024-11-22 15:45:42 UTC Build successful.
🟢 2024-11-22 15:46:11 UTC ydbd size 4.9 GiB changed* by -33.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: fb228ee merge: df16974 diff diff %
ydbd size 5 285 187 664 Bytes 5 285 153 536 Bytes -33.3 KiB -0.001%
ydbd stripped size 1 359 579 888 Bytes 1 359 564 592 Bytes -14.9 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 22, 2024

2024-11-22 14:08:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for df16974 has started.
2024-11-22 14:08:40 UTC Artifacts will be uploaded here
2024-11-22 14:11:47 UTC ya make is running...
🟡 2024-11-22 15:03:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15518 13989 0 2 1410 117

2024-11-22 15:04:31 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-22 15:16:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
118 (only retried tests) 10 0 0 1 107

🟢 2024-11-22 15:16:11 UTC Build successful.
🟡 2024-11-22 15:16:31 UTC ydbd size 2.5 GiB changed* by +279.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0d355e6 merge: df16974 diff diff %
ydbd size 2 691 446 096 Bytes 2 691 732 176 Bytes +279.4 KiB +0.011%
ydbd stripped size 482 135 088 Bytes 482 181 360 Bytes +45.2 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin requested a review from snaury November 22, 2024 16:08
@azevaykin azevaykin merged commit 663d308 into ydb-platform:main Nov 22, 2024
5 checks passed
@azevaykin azevaykin deleted the Uint8Restriction branch November 22, 2024 18:48
azevaykin added a commit to azevaykin/ydb that referenced this pull request Nov 22, 2024
azevaykin added a commit to azevaykin/ydb that referenced this pull request Nov 22, 2024
azevaykin added a commit that referenced this pull request Nov 25, 2024
azevaykin added a commit that referenced this pull request Nov 25, 2024
dahbka-lis pushed a commit to dahbka-lis/ydb that referenced this pull request Nov 25, 2024
dahbka-lis pushed a commit to dahbka-lis/ydb that referenced this pull request Nov 25, 2024
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 30, 2024
azevaykin added a commit to azevaykin/ydb that referenced this pull request Dec 22, 2024
azevaykin added a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants