Skip to content

move ReportLatencyCounters to common call #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siarheivesialou merged 2 commits into from
Jan 24, 2024
Merged

move ReportLatencyCounters to common call #1193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2792402
move ReportLatencyCounters to ReplyWithError
siarheivesialou Jan 22, 2024
a041166
fix compile
siarheivesialou Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions ydb/core/http_proxy/http_req.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,13 +409,23 @@ namespace NKikimr::NHttpProxy {

HttpContext.ResponseData.Status = status;
HttpContext.ResponseData.ErrorText = errorText;
HttpContext.DoReply(ctx, issueCode);
ReplyToHttpContext(ctx, issueCode);

ctx.Send(AuthActor, new TEvents::TEvPoisonPill());

TBase::Die(ctx);
}

void ReplyToHttpContext(const TActorContext& ctx, std::optional<size_t> issueCode = std::nullopt) {
ReportLatencyCounters(ctx);

if (issueCode.has_value()) {
HttpContext.DoReply(ctx, issueCode.value());
} else {
HttpContext.DoReply(ctx);
}
}

void ReportInputCounters(const TActorContext& ctx) {

if (InputCountersReported) {
Expand Down Expand Up @@ -478,7 +488,6 @@ namespace NKikimr::NHttpProxy {
HttpContext.ContentType == MIME_CBOR);
FillOutputCustomMetrics<TProtoResult>(
*(dynamic_cast<TProtoResult*>(ev->Get()->Message.Get())), HttpContext, ctx);
ReportLatencyCounters(ctx);
/* deprecated metric: */ ctx.Send(MakeMetricsServiceID(),
new TEvServerlessProxy::TEvCounter{1, true, true,
BuildLabels(Method, HttpContext, "api.http.success_per_second", setStreamPrefix)
Expand All @@ -495,7 +504,7 @@ namespace NKikimr::NHttpProxy {
{"code", "200"},
{"name", "api.http.data_streams.response.count"}}
});
HttpContext.DoReply(ctx);
ReplyToHttpContext(ctx);
} else {
auto retryClass =
NYdb::NPersQueue::GetRetryErrorClass(ev->Get()->Status->GetStatus());
Expand Down